Skip to content

[Misc] Remove override_attention_dtype #48684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangxiyuan wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −15
Open

[Misc] Remove override_attention_dtype #48684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions vllm/config/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project

import warnings
from collections.abc import Callable
from dataclasses import InitVar, field
from functools import cached_property
Expand Down Expand Up @@ -323,8 +322,6 @@ class ModelConfig:
- "transformers" will use the Transformers model implementation.
- "terratorch" will use the TerraTorch model implementation.
"""
override_attention_dtype: str | None = None
"""Override dtype for attention"""
logits_processors: list[str | type[LogitsProcessor]] | None = None
"""One or more logits processors' fully-qualified class names or class
definitions"""
Expand Down Expand Up @@ -402,7 +399,6 @@ def compute_hash(self) -> str:
"config_format",
"hf_token",
"hf_overrides",
"override_attention_dtype",
"logits_processors",
"io_processor_plugin",
"pooler_config",
Expand Down Expand Up @@ -532,12 +528,6 @@ def __post_init__(

self.maybe_pull_model_tokenizer_for_runai(self.model, self.tokenizer)

if self.override_attention_dtype is not None and not current_platform.is_rocm():
warnings.warn(
"override-attention-dtype is set but not using ROCm platform",
stacklevel=2,
)

if self.enable_sleep_mode:
if not current_platform.is_sleep_mode_available():
raise ValueError("Sleep mode is not supported on current platform.")
Expand Down
5 changes: 0 additions & 5 deletions vllm/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,6 @@ class EngineArgs:
ModelConfig, "override_generation_config"
)
model_impl: str = ModelConfig.model_impl
override_attention_dtype: str | None = ModelConfig.override_attention_dtype
attention_backend: AttentionBackendEnum | None = AttentionConfig.backend

calculate_kv_scales: bool = CacheConfig.calculate_kv_scales
Expand Down Expand Up @@ -876,9 +875,6 @@ def add_cli_args(parser: FlexibleArgumentParser) -> FlexibleArgumentParser:
"--enable-cumem-allocator", **model_kwargs["enable_cumem_allocator"]
)
model_group.add_argument("--model-impl", **model_kwargs["model_impl"])
model_group.add_argument(
"--override-attention-dtype", **model_kwargs["override_attention_dtype"]
)
model_group.add_argument(
"--logits-processors", **model_kwargs["logits_processors"]
)
Expand Down Expand Up @@ -1683,7 +1679,6 @@ def create_model_config(self) -> ModelConfig:
enable_sleep_mode=self.enable_sleep_mode,
enable_cumem_allocator=self.enable_cumem_allocator,
model_impl=self.model_impl,
override_attention_dtype=self.override_attention_dtype,
logits_processors=self.logits_processors,
video_pruning_rate=self.video_pruning_rate,
mm_tensor_ipc=self.mm_tensor_ipc,
Expand Down
Loading