[Bugfix][ROCm] Only run FP8 AITER MLA prefill when using FP8 KV#48712
Open
simondanielsson wants to merge 1 commit into
Open
[Bugfix][ROCm] Only run FP8 AITER MLA prefill when using FP8 KV#48712simondanielsson wants to merge 1 commit into
simondanielsson wants to merge 1 commit into
Conversation
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Even when KV is not FP8, the FP8 PS ASM prefill kernel's persistent buffers are both (a) initialized/reserved and (b) filled with metadata (through
_build_fp8_prefill_ps_metadata) in every forward.Specifically the latter leads to performance degradation when using BF16 as
_build_fp8_prefill_ps_metadatais a host-side function with several sync memcpys in it, causing a unnecessary H->D sync before every forward.Co-authored with @olka-amd.
Test Plan
export VLLM_ROCM_USE_AITER=1 vllm bench deepseek-ai/DeepSeek-V3-0324 \ --tensor-parallel-size 8 \ --enable-expert-parallel \ --gpu-memory-utilization 0.8 \ --max-model-len 16KTest Result
This branch:
Nightly:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.