Add minimal test-selection trace hooks - #51982
Closed
khluu wants to merge 2 commits into
Closed
Conversation
khluu
force-pushed
the
ci-test-selection-trace-mvp
branch
from
August 12, 2026 11:22
471cb96 to
577b692
Compare
khluu
force-pushed
the
ci-test-selection-trace-mvp
branch
from
August 18, 2026 22:56
7e29c1a to
56a07a9
Compare
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
khluu
force-pushed
the
ci-test-selection-trace-mvp
branch
from
August 19, 2026 06:56
56a07a9 to
27d8e11
Compare
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
Member
Author
|
Superseded by the automatic ci-infra-only design in vllm-project/ci-infra#469. The branch now removes the explicit trace_mode and image post-build hook, leaving no net vLLM source change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
trace_mode: kernel-setto the existing FlashMLA/H100 test definitionci-infraThis final vLLM diff is exactly 2 files and 12 inserted lines. Collector code, artifact schemas, Nsight parsing, static kernel-map export, graph construction, snapshot policy, and selection all live in the companion
ci-infradraft.Why
The required evidence is deliberately small: unordered per-test executed repository line sets and unordered per-test launched mangled CUDA kernel identity sets. Ordered call/return traces, Python launch stacks, sampling, deep modes, and retained Nsight timelines are out of scope.
The thin callout lets
ci-infraload one exact collector version into both runtime jobs and the completed image build without vendoring CI implementation into vLLM.Companion ci-infra draft: vllm-project/ci-infra#469
Impact and safety
ci-infraexplicitly injectsVLLM_CI_IMAGE_POST_BUILD_HOOKmaintreeValidation
.buildkite/image_build/image_build.shThe rewritten image-build hook has unit, render, packaging, and shell validation through the companion draft but has not yet had a live Buildkite run. This PR remains a draft for human line-by-line review and that live gate.
Contribution notes
AI assistance was used in implementation and validation. The human submitter must review every changed line and understand the design before moving this PR out of draft.