[CI] Shard extended pooling model tests - #52322
Merged
Merged
Conversation
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
| depends_on: | ||
| - image-build-amd | ||
| commands: | ||
| - pytest -v -s models/language/pooling -m 'not core_model' |
Member
There was a problem hiding this comment.
we can shard that here too but probably with parallelism 2 (i think 4 would be too much for the amd mirror)
Member
Author
There was a problem hiding this comment.
Done in f391ffb. The AMD mirror now uses parallelism 2 and passes the Buildkite shard count and shard ID to pytest.
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: khluu <khluu000@gmail.com>
Alessandra005
pushed a commit
to Alessandra005/vllm
that referenced
this pull request
Aug 17, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Signed-off-by: khluu <khluu000@gmail.com> Signed-off-by: Alessandra005 <aurib032@fiu.edu>
zyp2014
pushed a commit
to zyp2014/vllm
that referenced
this pull request
Aug 21, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Signed-off-by: khluu <khluu000@gmail.com>
wyettzeng
pushed a commit
to wyettzeng/vllm
that referenced
this pull request
Aug 21, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Signed-off-by: khluu <khluu000@gmail.com> Signed-off-by: Wyett <wyettzeng@gmail.com>
zufangzhu
pushed a commit
to zufangzhu/vllm
that referenced
this pull request
Aug 24, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Signed-off-by: khluu <khluu000@gmail.com> Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
khushali9
pushed a commit
to khushali9/vllm
that referenced
this pull request
Aug 29, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Signed-off-by: khluu <khluu000@gmail.com> Signed-off-by: khushali9 <khushali.desai9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
language-models-test-extended-poolingas four deterministic pytest shardsWhy
Buildkite build #83851 took 72 minutes for this job. Its recent passed-run distribution is 70 minutes median, 82 minutes p90, and 112 minutes max. Four shards leave substantially more headroom than three shards for the 30-minute target while preserving the same test selection.
The AMD behavior depends on ci-infra #473, which adds the backward-compatible
mirror.amd.parallelismoverride. This PR must not merge before that prerequisite.Validation
uvx pre-commit run --files .buildkite/test_areas/models_language.yamlimage-buildandpre-commitdependencies8f9a4d08e09b18d42d8d0ff3387a37ee77d4b53cand ci-infra indexSelectLargeIndex: block: [308,0,0], thread: [95,0,0] AssertionsrcIndex < srcSelectDimSizefailed. #473e006ba64b39ffd4f179824f088ff10e88af5635f: passedparallelism: 4; AMD mirrorparallelism: 1; AMD custom command remains unsharded with no--num-shards/--shard-idflagssrcIndex < srcSelectDimSizefailed. #473 regression suite: 75/75 generator tests passedDuplicate-work check
Searched open PRs by the exact step key and sharding keywords. Existing PR #42222 changes source-dependency gating, not execution sharding, so this does not duplicate it.
AI assistance was used to prepare and validate this CI-only change.