forked from KhronosGroup/SPIRV-LLVM-Translator
-
Notifications
You must be signed in to change notification settings - Fork 0
Add packed matrix layout support for SPV_INTEL_joint_matrix #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
7
commits into
joint-matrix-align-to-spec
Choose a base branch
from
copilot/add-joint-matrix-implementation
base: joint-matrix-align-to-spec
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add packed matrix layout support for SPV_INTEL_joint_matrix #4
Copilot
wants to merge
7
commits into
joint-matrix-align-to-spec
from
copilot/add-joint-matrix-implementation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot stopped work on behalf of
vmaksimo due to an error
December 1, 2025 13:21
ad82f36 to
61295d8
Compare
Owner
|
@copilot I updated the branch so now it is buildable and passing all lit tests. We need to actually implement packed matrix layout and cover it with the test |
Co-authored-by: vmaksimo <[email protected]>
Co-authored-by: vmaksimo <[email protected]>
Author
Implemented the packed matrix layout support in commit 61a833e. The changes:
|
Co-authored-by: vmaksimo <[email protected]>
Co-authored-by: vmaksimo <[email protected]>
Copilot
AI
changed the title
[WIP] Add missing implementation for SPV_INTEL_joint_matrix
Add packed matrix layout support for SPV_INTEL_joint_matrix
Dec 1, 2025
…ix-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the packed matrix layout support for the SPV_INTEL_joint_matrix extension as specified in the SPV_INTEL_joint_matrix specification.
Changes Made
CapabilityPackedCooperativeMatrixINTELconstant definition inspirv_internal.hppSPIRVNameMapEnum.hSPIRVEnum.h(depends onJointMatrixINTEL)SPIRVTypeJointMatrixINTEL::getRequiredCapability()inSPIRVType.cppto return thePackedCooperativeMatrixINTELcapability when the matrix layout isPackedA(2) orPackedB(3)joint_matrix_packed.llcovering both forward translation (LLVM IR → SPIR-V) and reverse translation (SPIR-V → LLVM IR)Testing
The test verifies that the
PackedCooperativeMatrixINTELcapability is correctly emitted in SPIR-V when using packed matrix layouts, and that the types are correctly preserved during reverse translation.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.