Skip to content

Conversation

Copy link

Copilot AI commented Dec 1, 2025

Implements the packed matrix layout support for the SPV_INTEL_joint_matrix extension as specified in the SPV_INTEL_joint_matrix specification.

Changes Made

  • Added CapabilityPackedCooperativeMatrixINTEL constant definition in spirv_internal.hpp
  • Added name mapping for the capability in SPIRVNameMapEnum.h
  • Added capability dependency in SPIRVEnum.h (depends on JointMatrixINTEL)
  • Modified SPIRVTypeJointMatrixINTEL::getRequiredCapability() in SPIRVType.cpp to return the PackedCooperativeMatrixINTEL capability when the matrix layout is PackedA (2) or PackedB (3)
  • Created test file joint_matrix_packed.ll covering both forward translation (LLVM IR → SPIR-V) and reverse translation (SPIR-V → LLVM IR)

Testing

The test verifies that the PackedCooperativeMatrixINTEL capability is correctly emitted in SPIR-V when using packed matrix layouts, and that the types are correctly preserved during reverse translation.

Original prompt

Add missing implementation for the spec https://github.com/MrSidims/llvm/blob/update-matrix-spec-2/sycl/doc/design/spirv-extensions/SPV_INTEL_joint_matrix.asciidoc


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vmaksimo
Copy link
Owner

vmaksimo commented Dec 1, 2025

@copilot I updated the branch so now it is buildable and passing all lit tests. We need to actually implement packed matrix layout and cover it with the test

Copy link
Author

Copilot AI commented Dec 1, 2025

@copilot I updated the branch so now it is buildable and passing all lit tests. We need to actually implement packed matrix layout and cover it with the test

Implemented the packed matrix layout support in commit 61a833e. The changes:

  • Added CapabilityPackedCooperativeMatrixINTEL constant and name mapping
  • Modified SPIRVTypeJointMatrixINTEL::getRequiredCapability() to return the capability when layout is PackedA (2) or PackedB (3)
  • Added test file joint_matrix_packed.ll covering both forward and reverse translation

Copilot AI changed the title [WIP] Add missing implementation for SPV_INTEL_joint_matrix Add packed matrix layout support for SPV_INTEL_joint_matrix Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants