fix(scan): require a real bucket listing body before flagging s3 exposure - #282
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage ? 54.87%
=======================================
Files ? 81
Lines ? 6887
Branches ? 0
=======================================
Hits ? 3779
Misses ? 2836
Partials ? 272 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pr summary3 files changed (+164 -6)
|
47349cc to
826825e
Compare
vmfunc
left a comment
There was a problem hiding this comment.
good catch on the 200-alone false positive, and the tests actually pin the pre-fix bug (200 + AccessDenied body). LimitReader keeps the read bounded and DrainClose still returns the conn, so no leak.
one thing worth noting: the denial markers are matched with strings.Contains over the whole body, not scoped to .... so a genuinely listable bucket whose listing contains an object key like AccessDenied.txt or a PermanentRedirect/ prefix would get scored not-public. edge case, but if you want to tighten it later, matching AccessDenied would remove the collision. not blocking.
in.
No description provided.