Skip to content

fix(scan): report the found url in dork results and dedupe by url - #283

Merged
vmfunc merged 1 commit into
vmfunc:mainfrom
TBX3D:fix/dork-url-field
Jul 22, 2026
Merged

vmfunc merged 1 commit into
vmfunc:mainfrom
TBX3D:fix/dork-url-field

Conversation

@TBX3D

@TBX3D TBX3D commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@TBX3D
TBX3D requested a review from vmfunc as a code owner July 3, 2026 19:29
@github-actions github-actions Bot added the size/m <200 lines changed label Jul 3, 2026
@codecov-commenter

codecov-commenter commented Jul 3, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@7ea1cd2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/scan/dork.go 94.44% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage        ?   54.86%           
=======================================
  Files           ?       81           
  Lines           ?     6888           
  Branches        ?        0           
=======================================
  Hits            ?     3779           
  Misses          ?     2840           
  Partials        ?      269           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added scan changes to scan engine tests test changes labels Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

pr summary

4 files changed (+81 -16)

category files
go source 4
tests 2

@TBX3D
TBX3D force-pushed the fix/dork-url-field branch from c52b6f4 to 2aaf618 Compare July 10, 2026 00:08

@vmfunc vmfunc left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch on the actual bug here, Url was holding the dork query the whole time so key("dork", d.Url) in flattenDork was keying findings on the query instead of the hit. groupDorkResults dedup is correct, empty-url drop and order-preserving map both right. in.

@vmfunc
vmfunc merged commit 64a2250 into vmfunc:main Jul 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scan changes to scan engine size/m <200 lines changed tests test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants