Skip to content

fix(frameworks): stop gatsby and svelte prose from faking detection - #285

Merged
vmfunc merged 1 commit into
vmfunc:mainfrom
TBX3D:fix/frameworks-prose-fp
Jul 22, 2026
Merged

vmfunc merged 1 commit into
vmfunc:mainfrom
TBX3D:fix/frameworks-prose-fp

Conversation

@TBX3D

@TBX3D TBX3D commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@TBX3D
TBX3D requested a review from vmfunc as a code owner July 3, 2026 19:29
@codecov-commenter

codecov-commenter commented Jul 3, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7ea1cd2). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage        ?   55.09%           
=======================================
  Files           ?       81           
  Lines           ?     6872           
  Branches        ?        0           
=======================================
  Hits            ?     3786           
  Misses          ?     2816           
  Partials        ?      270           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added scan changes to scan engine tests test changes size/s <50 lines changed labels Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

pr summary

3 files changed (+11 -3)

category files
go source 3
tests 1

@TBX3D
TBX3D force-pushed the fix/frameworks-prose-fp branch from 25b1687 to 27da3a8 Compare July 10, 2026 00:08

@vmfunc vmfunc left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean fix. the math checks out: after dropping the prefixes, gatsby needs ___gatsby or /page-data/ and svelte needs __svelte or svelte/internal, all of which only show up in a real bundle, and each still clears the 0.3 center on a single strong hit so recall on genuine pages holds. no false-negative regression that matters. /page-data/ over page-data.json is the better call too, its the actual served path structure, not a string prose can drop. in.

@vmfunc
vmfunc merged commit 251be84 into vmfunc:main Jul 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scan changes to scan engine size/s <50 lines changed tests test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants