fix(modules): guard ignition, web.config and appsettings against soft-404 shells - #286
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage ? 54.75%
=======================================
Files ? 81
Lines ? 6874
Branches ? 0
=======================================
Hits ? 3764
Misses ? 2842
Partials ? 268 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pr summary6 files changed (+61 -3)
|
vmfunc
left a comment
There was a problem hiding this comment.
good change. the ignition one is the real win: dropping the bare can_execute_commands word matcher for "can_execute_commands"\s*:\s*(?:true|false) anchors on the json shape the endpoint actually emits, so an spa bundle referencing the field as a js property stops tripping it. negative-matcher AND semantics check out in checkMatcher, and the guard regexes are fine under re2.
one thing to keep in mind, not blocking: the <(!doctype|html|head|title|body)[ >] guard will also suppress a genuine web.config that embeds an html sample inside an xml comment. narrow, and worth it against the docs-page fp, just noting it.
this sits on top of the grafana/debug+webserver module bundle and the app-config PR, not main. fine to land once those are in.
in.
No description provided.