Skip to content

feat(modules): add s3, gcs and azure bucket listing modules - #288

Merged
vmfunc merged 1 commit into
vmfunc:mainfrom
TBX3D:feat/bucket-listing-exposure
Jul 22, 2026
Merged

vmfunc merged 1 commit into
vmfunc:mainfrom
TBX3D:feat/bucket-listing-exposure

Conversation

@TBX3D

@TBX3D TBX3D commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@TBX3D
TBX3D requested a review from vmfunc as a code owner July 3, 2026 19:29
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7ea1cd2). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage        ?   54.75%           
=======================================
  Files           ?       81           
  Lines           ?     6874           
  Branches        ?        0           
=======================================
  Hits            ?     3764           
  Misses          ?     2841           
  Partials        ?      269           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added size/l <500 lines changed modules changes to scan modules tests test changes labels Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

pr summary

4 files changed (+353 -0)

category files
go source 1
tests 1

@vmfunc vmfunc left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the matcher shape is right. status 200 AND the structural regex AND the negative word gate on the error bodies is exactly how you avoid the 200+AccessDenied trap, and the tests cover that case directly (locked bucket returning 200 AccessDenied, 403, NoSuchBucket). anchoring the s3 regex to the s3.amazonaws.com/doc/2006-03-01 xmlns is the right call too, spaces/minio/etc all emit that same namespace so you get s3-compatible coverage for free.

one non-blocking nit: the negative word lists match anywhere in the body, so an object key named literally AccessDenied.txt (or NoSuchBucket) would suppress a real hit. edge case and the xmlns regex already does the heavy lifting, so leave it.

in.

@vmfunc
vmfunc merged commit 1ea8eff into vmfunc:main Jul 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modules changes to scan modules size/l <500 lines changed tests test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants