feat(info): add roundcube and zimbra webmail fingerprints - #291
Conversation
fingerprint roundcube via its login-page body markers and zimbra via its web client markers, both anded with status 200 and prose-trap negatives to avoid matching pages that merely mention the products.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage ? 54.72%
=======================================
Files ? 81
Lines ? 6874
Branches ? 0
=======================================
Hits ? 3762
Misses ? 2843
Partials ? 269 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pr summary3 files changed (+262 -0)
|
vmfunc
left a comment
There was a problem hiding this comment.
both matchers are anchored right. roundcube AND's the product string with the new rcube_webmail() bootstrap, zimbra AND's the license string with CLIENT_VERSION, so neither trips on prose that just mentions the product. nice touch on the zimbra extractor: ([^"@]...) drops the unbuilt @buildVersion@ placeholder instead of capturing garbage. regexes are all RE2, no backtracking to worry about. tests hit the cases that matter (prose trap, plain 200, 404, version present/absent).
in.
fingerprint roundcube via its login-page body markers and zimbra via
its web client markers, both anded with status 200 and prose-trap
negatives to avoid matching pages that merely mention the products.