Skip to content

feat(info): add roundcube and zimbra webmail fingerprints - #291

Merged
vmfunc merged 1 commit into
vmfunc:mainfrom
TBX3D:feat/webmail-fingerprints
Jul 22, 2026
Merged

vmfunc merged 1 commit into
vmfunc:mainfrom
TBX3D:feat/webmail-fingerprints

Conversation

@TBX3D

@TBX3D TBX3D commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

fingerprint roundcube via its login-page body markers and zimbra via
its web client markers, both anded with status 200 and prose-trap
negatives to avoid matching pages that merely mention the products.

fingerprint roundcube via its login-page body markers and zimbra via
its web client markers, both anded with status 200 and prose-trap
negatives to avoid matching pages that merely mention the products.
@TBX3D
TBX3D requested a review from vmfunc as a code owner July 3, 2026 19:29
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7ea1cd2). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage        ?   54.72%           
=======================================
  Files           ?       81           
  Lines           ?     6874           
  Branches        ?        0           
=======================================
  Hits            ?     3762           
  Misses          ?     2843           
  Partials        ?      269           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added size/l <500 lines changed modules changes to scan modules tests test changes labels Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

pr summary

3 files changed (+262 -0)

category files
go source 1
tests 1

@vmfunc vmfunc left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both matchers are anchored right. roundcube AND's the product string with the new rcube_webmail() bootstrap, zimbra AND's the license string with CLIENT_VERSION, so neither trips on prose that just mentions the product. nice touch on the zimbra extractor: ([^"@]...) drops the unbuilt @buildVersion@ placeholder instead of capturing garbage. regexes are all RE2, no backtracking to worry about. tests hit the cases that matter (prose trap, plain 200, 404, version present/absent).

in.

@vmfunc
vmfunc merged commit a673eac into vmfunc:main Jul 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modules changes to scan modules size/l <500 lines changed tests test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants