This repository was archived by the owner on Jun 17, 2024. It is now read-only.
read resource_configuration also from deployments with non-VM resources #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcel Juhnke [email protected]
This PR changes the way how
resource_configurationis read back from a vRA Deployment into the state file.Previously, only the data of vSphere VMs (resource type
Infrastructure.Virtual) has been read back into the state filesresource_configurationblock. All non-VM resources in a deployment have been ignored in the state file.This was also because the vRA API sends back the VM resources in a deployment directly in the ResourceView response, whereas for custom resource types only the Deployment itself would get sent back with a link to its Child Resources.
So this PR changes the logic on how Deployment details are read.
At first, only the Deployment itself is processed and then the
GET: Child Resourceslink in the response is used to retrieve all child resources (which then includes both VMs and non-VM resources).Those child resources then are added into the
resource_configurationset, no matter if they are a VM or not (and including the IP address just for VMs, of course).This implements #68