This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Improve type inference for bus API methods #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Kim <[email protected]>
jooskim
force-pushed
the
topic/kjosh/type-inference-improvement
branch
from
85984e3 to
f023ad2
Compare
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 62 62
Lines 3715 3715
Branches 441 441
=======================================
Hits 3480 3480
Misses 116 116
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jooskim
changed the title
daveshanley
approved these changes
Jan 11, 2022
Contributor
daveshanley
left a comment
daveshanley
left a comment
There was a problem hiding this comment.
Looks good to me, makes things more flexible. Nice work!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves type inference for various bus API methods such as
listenStream()andrequestOnce()etc.Signed-off-by: Josh Kim [email protected]