Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Conversation

@daveshanley
Copy link
Contributor

After a long extended period, applications will start failing when performing clean-up after disconnecting from a broker. It's because we're checking for connectedBrokers on a channel that's cleaned up.

This code adds a check for the existence of the channel before trying to modify or read connectedBrokers

Screen Shot 2022-01-11 at 11 46 06 AM
Screen Shot 2022-01-11 at 11 45 58 AM

Signed-off-by: Dave Shanley [email protected]

@vmwclabot
Copy link

@daveshanley, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

After a long extended period of time, applications will start failing when performing clean-up after disconnecting from a broker. It's because we're checking for `connectedBrokers` on a channel that's already been cleaned up.

Signed-off-by: Dave Shanley <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.03 ⚠️

Comparison is base (4725d8b) 93.64% compared to head (f7ed0fe) 93.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   93.64%   93.62%   -0.03%     
==========================================
  Files          62       62              
  Lines        3716     3717       +1     
  Branches      442      443       +1     
==========================================
  Hits         3480     3480              
  Misses        117      117              
- Partials      119      120       +1     
Flag Coverage Δ
unittests 93.62% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/bridge/broker-connector.ts 90.02% <33.33%> (-0.26%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vmwclabot
Copy link

@daveshanley, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants