-
Notifications
You must be signed in to change notification settings - Fork 94
feat: migrate cds-icon, cds/core styles and drop cds/core dependency #2101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
d8e31f6 to
9fad93a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
.storybook/stories/vertical-nav/vertical-nav-header-and-divider.stories.ts
Outdated
Show resolved
Hide resolved
.storybook/stories/vertical-nav/vertical-nav-routing.stories.ts
Outdated
Show resolved
Hide resolved
0fe3bed to
1fb91d4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
219a716 to
13d7498
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR introduces visual changes: da6a9c8 |
|
This PR introduces visual changes: 454fe61 |
|
This PR introduces visual changes: 512c49b |
valentin-mladenov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-2187
What is the new behavior?
Does this PR introduce a breaking change?
BREAKING CHANGES:
@clr/angulardrops the dependency of@cds/coreand the only support features are migrated to@clr/angular. This includescds-iconcomponent, CSS tokens, CSS utilities:cds-layout,cds-list,cds-text,cds-divider.@clr/uinow includes all the necessary styles and the style imports from@cds/corecan be removed.@cds/coredependency should be removed and icon imports should be changed from@cds/core/iconto@clr/angular.cds-iconis now an Angular component and all [attr.] binding should be changed to normal Angular bindings. For example:[attr.shape]="shape"]should become[shape]="shape".--cds-global-typography-*tokens are now removed and should be replaced with the same ones with prefix--cds-alias-typography-*Other information