Skip to content

Conversation

@dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented Nov 11, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2187

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

BREAKING CHANGES:

  • @clr/angular drops the dependency of @cds/core and the only support features are migrated to @clr/angular. This includes cds-icon component, CSS tokens, CSS utilities: cds-layout, cds-list, cds-text, cds-divider.
  • @clr/ui now includes all the necessary styles and the style imports from @cds/core can be removed.
  • @cds/core dependency should be removed and icon imports should be changed from @cds/core/icon to @clr/angular.
  • cds-icon is now an Angular component and all [attr.] binding should be changed to normal Angular bindings. For example: [attr.shape]="shape"] should become [shape]="shape".
  • deprecated --cds-global-typography-* tokens are now removed and should be replaced with the same ones with prefix --cds-alias-typography-*
  • ClrIconModule is now deprecated and should be replaced with standalone ClrIcon.

Other information

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR or explore it in StackBlitz
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/move_core branch 3 times, most recently from d8e31f6 to 9fad93a Compare November 11, 2025 14:03
@dtsanevmw dtsanevmw changed the title wip: migrate core to ng-clarity feat: migrate cds-icon and @cds/core styles, drop @cds/core dependency Nov 12, 2025
@dtsanevmw dtsanevmw changed the title feat: migrate cds-icon and @cds/core styles, drop @cds/core dependency feat: migrate cds-icon, @cds/core styles and drop @cds/core dependency Nov 12, 2025
@dtsanevmw dtsanevmw changed the title feat: migrate cds-icon, @cds/core styles and drop @cds/core dependency feat: migrate cds-icon, cds/core styles and drop cds/core dependency Nov 12, 2025
@dtsanevmw dtsanevmw self-assigned this Nov 12, 2025
@dtsanevmw dtsanevmw requested a review from a team November 12, 2025 12:06
@dtsanevmw dtsanevmw marked this pull request as ready for review November 12, 2025 12:06
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Contributor

This PR introduces visual changes: da6a9c8
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/move_core
git fetch https://github.com/vmware-clarity/ng-clarity.git da6a9c89934604e9c977ea9767eeea52d850579b
git cherry-pick da6a9c89934604e9c977ea9767eeea52d850579b
git push

@github-actions
Copy link
Contributor

This PR introduces visual changes: 454fe61
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/move_core
git fetch https://github.com/vmware-clarity/ng-clarity.git 454fe61915d44144e9a8b23c385064bb8edf8fb2
git cherry-pick 454fe61915d44144e9a8b23c385064bb8edf8fb2
git push

@github-actions
Copy link
Contributor

This PR introduces visual changes: 512c49b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/move_core
git fetch https://github.com/vmware-clarity/ng-clarity.git 512c49b3793d1c1bedd9fc27ffb981f64abd13c4
git cherry-pick 512c49b3793d1c1bedd9fc27ffb981f64abd13c4
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants