[velero] Refactoring labels and annotations#281
Open
nlamirault wants to merge 16 commits intovmware-tanzu:mainfrom
Open
[velero] Refactoring labels and annotations#281nlamirault wants to merge 16 commits intovmware-tanzu:mainfrom
nlamirault wants to merge 16 commits intovmware-tanzu:mainfrom
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
jenting
requested changes
Jul 5, 2021
Collaborator
jenting
left a comment
jenting
left a comment
There was a problem hiding this comment.
Thank you for your improvement to make the chart easier to read and configure.
But the CI is not passed, could you please take a look?
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Author
|
@jenting i don't understard CI error. Node not ready ? |
Collaborator
|
Okay, I'll look at it later. |
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Collaborator
|
I push a commit to test it :) |
jenting
requested changes
Jul 6, 2021
Comment on lines
20
to
22
| {{- with .Values.labels }} | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
Collaborator
There was a problem hiding this comment.
With removing these lines, will this make the labels duplicated?
Comment on lines
+9
to
+11
| {{- if .Values.customAnnotations }} | ||
| {{- toYaml .Values.customAnnotations | nindent 4 }} | ||
| {{- end }} |
Collaborator
There was a problem hiding this comment.
Personally, I'd prefer.
{{- With .Values.customAnnotations }}
{{- toYaml . | nindent 4 }}
{{- end }}
This makes the code simpler.
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Collaborator
|
CI was failed, could you please take a look? Error: templates/: template: velero/templates/schedule.yaml:11:20: executing "velero/templates/schedule.yaml" at <.Values.customAnnotations>: nil pointer evaluating interface {}.customAnnotations |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer:
namelabel on 2 resourcesChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero])