[velero] chore(upgrade-crds) double quote cp command for better shell compatibility#719
Closed
QuentinBtd wants to merge 1 commit intovmware-tanzu:mainfrom
Closed
Conversation
QuentinBtd
force-pushed
the
chore/upgrade-crds/double_quotes_cp_command
branch
from
873ce34 to
3c83f66
Compare
…ility Signed-off-by: Quentin BERTRAND <contact@quentinbertrand.fr>
QuentinBtd
force-pushed
the
chore/upgrade-crds/double_quotes_cp_command
branch
from
3c83f66 to
bf3624c
Compare
Collaborator
|
We don't rely on the cp command anymore, closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer:
I tried to use another kubectl image, like
alpine/kubectl. But runningnot works as well. The command needs to be quoted:
/bin/sh -c "cp `which sh` /tmp && cp `which kubectl` /tmp"Checklist
[velero])