Skip to content

Add IP Ranges to VDN CRD, as well as additional CEL markers#38

Open
ammujumdar-bcom wants to merge 6 commits intovmware-tanzu:masterfrom
ammujumdar-bcom:topic/ammujumdar/add-iprange-vdn-crd
Open

Add IP Ranges to VDN CRD, as well as additional CEL markers#38
ammujumdar-bcom wants to merge 6 commits intovmware-tanzu:masterfrom
ammujumdar-bcom:topic/ammujumdar/add-iprange-vdn-crd

Conversation

@ammujumdar-bcom
Copy link
Copy Markdown

@ammujumdar-bcom ammujumdar-bcom commented Apr 20, 2026

Add IP Ranges to VsphereDistributedNetwork CRD, as well as the following fields and CEL markers:

  • Network Mode Type (workload vs Management)
  • Ensure that IP Assignment Mode, Gateway, and subnet mask are either an IPv4 string OR empty
  • Require that IP Assignment Mode, Gateway, and subnet mask are set if mode is static, OR empty if mode is DHCP
  • Require that Network Name is DNS 1123 Subdomain
  • Ensure that IP Assignment Mode enum is either DHCP, static, or none, and default to static
  • Ensure that IP Assignment Mode field is immutable on updates

Note that these changes should be backward compatible, since the new fields are optional, and any CEL markers just enforce the already written expected behavior.

To test, verified that make generate-manifests works properly.

also ran:

/Users/ammujumdar/net-operator-api/hack/tools/bin/golangci-lint-kal run --config /Users/ammujumdar/net-operator-api/hack/.golangci-kal.yml  ./api/...
0 issues.

@ammujumdar-bcom ammujumdar-bcom force-pushed the topic/ammujumdar/add-iprange-vdn-crd branch from 901d1a9 to ac7f47a Compare April 20, 2026 17:47
@ammujumdar-bcom ammujumdar-bcom marked this pull request as ready for review April 20, 2026 17:50
@ammujumdar-bcom ammujumdar-bcom self-assigned this Apr 22, 2026
Comment thread api/v1alpha1/vspheredistributednetwork_types.go Outdated
Comment thread api/v1alpha1/vspheredistributednetwork_types.go Outdated
Comment thread api/v1alpha1/vspheredistributednetwork_types.go
Comment thread api/v1alpha1/vspheredistributednetwork_types.go
Comment thread api/v1alpha1/vspheredistributednetwork_types.go Outdated
Comment thread api/v1alpha1/vspheredistributednetwork_types.go Outdated
Comment thread api/v1alpha1/vspheredistributednetwork_types.go
@ammujumdar-bcom ammujumdar-bcom force-pushed the topic/ammujumdar/add-iprange-vdn-crd branch from 7324d11 to 21f122a Compare April 29, 2026 20:30
@ammujumdar-bcom ammujumdar-bcom requested a review from yahhhya April 29, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants