Enhance Subnet totalip calculation for shared subnet#1384
Open
yanjunz97 wants to merge 1 commit intovmware-tanzu:mainfrom
Open
Enhance Subnet totalip calculation for shared subnet#1384yanjunz97 wants to merge 1 commit intovmware-tanzu:mainfrom
yanjunz97 wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
d0cc387 to
1acb49b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
=======================================
Coverage 76.74% 76.75%
=======================================
Files 151 151
Lines 21307 21313 +6
=======================================
+ Hits 16353 16359 +6
Misses 3784 3784
Partials 1170 1170
🚀 New features to boost your workflow:
|
Signed-off-by: Yanjun Zhou <yanjun.zhou@broadcom.com>
1acb49b to
876b7f9
Compare
Contributor
|
@yanjunz97 for SubnetSet with auto-created Subnets, we should also check the subnet ip pool since in NSX 9.2, they plan to support multiple IPs per port. |
Contributor
Author
As currently we are not sure if dhcp server config api can reflect the correct allocated ip number, let's leave the multiple IPs issue in 9.2 and get this patch in to fix the issue with shared subnet. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can create IPReservation and SubnetPort on shared Subnet from NSX side.
Thus we need to always check the shared Subnet ip pool for totalip and allocated ip changes.
Testing done:
Static pool case
Created pre-created SubnetSet with 2 DHCPDeactivated Subnets
Created a IPReservation of size 2 and a SubnetPort on subnet test-2 from NSX
Created 3 SubnetPort CR on SubnetSet and observed 2 of them are created on subnet test-2 and 1 is created on subnet test.
Deleted the IPReservation on the Subnet test-2 and wait 2 minutes for the IP release.
Created another SubnetPort CR on SubnetSet and observed it created on subnet test-2.
DHCP Server case
Create pre-created subnetset with 2 DHCPServer Subnets
Created 2 vms on subnet-1 from VC and 2 vms from wcp
Created 1 vm on subnetset-2, observed it is created on subnet-2.