Restore SubnetPort with unchanged VIF#1385
Open
yanjunz97 wants to merge 1 commit intovmware-tanzu:mainfrom
Open
Restore SubnetPort with unchanged VIF#1385yanjunz97 wants to merge 1 commit intovmware-tanzu:mainfrom
yanjunz97 wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
yanjunz97
force-pushed
the
restore-subnetport-vif
branch
from
c9338a5 to
c0846ae
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 76.75% 76.75% -0.01%
==========================================
Files 151 151
Lines 21308 21328 +20
==========================================
+ Hits 16356 16371 +15
- Misses 3783 3785 +2
- Partials 1169 1172 +3
🚀 New features to boost your workflow:
|
heypnus
reviewed
Mar 11, 2026
Contributor
heypnus
left a comment
heypnus
left a comment
There was a problem hiding this comment.
looks good, just one minior comment
yanjunz97
force-pushed
the
restore-subnetport-vif
branch
from
c0846ae to
6f5b6b8
Compare
Signed-off-by: Yanjun Zhou <yanjun.zhou@broadcom.com>
yanjunz97
force-pushed
the
restore-subnetport-vif
branch
from
6f5b6b8 to
edc4f9c
Compare
heypnus
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
nsx.vmware.com/attachmentwith attachment id to PodAs NSX implementation is not done yet, always set RestoreVIF feature support to false.
Testing done:
After deployed this operator code, observe pod annotation being updated with annotation
Mocked NSXCheckVersion be true for
nsx.RestoreVIF. Created SubnetPort and Pod, shut down ncp and deleted the NSX SubnetPort. Forced restore, observed the NSX SubnetPort is restored with vif id unchanged.Regression test with nsx 9.1 also passed: Create Subnetport/Pod, shut down ncp and deleted the NSX SubnetPort. Forced restore, observed the vif id changes and Pod/VM network restored.