Validate shared subnets have the same access_mode#1387
Merged
TaoZou1 merged 1 commit intovmware-tanzu:mainfrom Mar 18, 2026
Merged
Validate shared subnets have the same access_mode#1387TaoZou1 merged 1 commit intovmware-tanzu:mainfrom
TaoZou1 merged 1 commit intovmware-tanzu:mainfrom
Conversation
TaoZou1
force-pushed
the
validsharedsubnet
branch
from
e76c3b3 to
dc541fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
==========================================
+ Coverage 76.74% 76.76% +0.01%
==========================================
Files 151 151
Lines 21307 21312 +5
==========================================
+ Hits 16353 16361 +8
+ Misses 3784 3783 -1
+ Partials 1170 1168 -2
🚀 New features to boost your workflow:
|
lxiaopei
reviewed
Mar 12, 2026
TaoZou1
force-pushed
the
validsharedsubnet
branch
from
dc541fd to
51bd46e
Compare
lxiaopei
reviewed
Mar 12, 2026
TaoZou1
force-pushed
the
validsharedsubnet
branch
from
51bd46e to
9477865
Compare
All the shared subnets added to the subnetset should have the same access_mode
TaoZou1
force-pushed
the
validsharedsubnet
branch
from
9477865 to
abbe122
Compare
Contributor
Author
|
/e2e |
yanjunz97
approved these changes
Mar 13, 2026
Contributor
Author
|
/e2e |
lxiaopei
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the shared subnets added to the subnetset should have the same access_mode
Test Done:
k get subnet -ndev
NAME ACCESSMODE IPV4SUBNETSIZE NETWORKADDRESSES
subnet3 Public 32 192.168.0.96/27
subnet4 PrivateTGW 32 10.246.0.96/27
k apply -f subnetset.yaml -ndev
Error from server (Forbidden): error when creating "subnetset.yaml": admission webhook "subnetset.validating.crd.nsx.vmware.com" denied the request: Subnets in SubnetSet dev/subnetset1 must have the same AccessMode, found different AccessModes: [Public, PrivateTGW]