Skip to content

[DRAFT]read insecure flag from config instead of hardcoding true#1390

Open
poojav25 wants to merge 1 commit intovmware-tanzu:mainfrom
poojav25:flag
Open

[DRAFT]read insecure flag from config instead of hardcoding true#1390
poojav25 wants to merge 1 commit intovmware-tanzu:mainfrom
poojav25:flag

Conversation

@poojav25
Copy link

No description provided.

@zhengxiexie
Copy link
Contributor

Can one of the admins verify this patch?

@poojav25 poojav25 changed the title read insecure flag from config instead of hardcoding true [DRAFT]read insecure flag from config instead of hardcoding true Mar 11, 2026
Copy link

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.75%. Comparing base (4ba0355) to head (d892f8a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1390   +/-   ##
=======================================
  Coverage   76.74%   76.75%           
=======================================
  Files         151      151           
  Lines       21307    21307           
=======================================
+ Hits        16353    16355    +2     
+ Misses       3784     3783    -1     
+ Partials     1170     1169    -1     
Flag Coverage Δ
unit-tests 76.75% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/client.go 94.90% <100.00%> (ø)
pkg/nsx/cluster.go 59.53% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants