Subnet: mixed-mode — static poolRanges with DHCPServer#1421
Open
poojav25 wants to merge 3 commits intovmware-tanzu:mainfrom
Open
Subnet: mixed-mode — static poolRanges with DHCPServer#1421poojav25 wants to merge 3 commits intovmware-tanzu:mainfrom
poojav25 wants to merge 3 commits intovmware-tanzu:mainfrom
Conversation
Allow static IP allocation alongside DHCPServer on the same VPC Subnet. Add structured poolRanges on staticIPAllocation, CEL and webhook validation, NSX builder/compare/reverse-mapper wiring, util helpers, tests and samples. Bump NSX Go SDK for StaticIpAllocation.PoolRanges.
Contributor
|
Can one of the admins verify this patch? |
salv-orlando
reviewed
May 5, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
+ Coverage 75.51% 77.07% +1.56%
==========================================
Files 154 154
Lines 26420 22105 -4315
==========================================
- Hits 19951 17038 -2913
+ Misses 5265 3859 -1406
- Partials 1204 1208 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports mixed mode on Subnet: subnetDHCPConfig.mode=DHCPServer together with advancedConfig.staticIPAllocation.enabled=true and optional poolRanges (static pool); NSX gets static_ip_allocation.pool_ranges. CEL + webhook validate ranges and DHCPRelay conflicts; builder, compare, and NSX→CR mapping handle the new field. staticIPAllocation.enabled immutability is unchanged. SDK bumped for StaticIpAllocation.PoolRanges. Tests and sample CR updated.