Conversation
|
Thanks @masap for the PR. We should also periodically review the weekly trivy scan workflow for sonobuoy to address vuln earlier: https://github.com/vmware-tanzu/sonobuoy/actions/runs/15949670484/job/44987968467 |
|
@masap Think you could add the fix for https://github.com/vmware-tanzu/sonobuoy/actions/runs/16699265919/job/47267729568 And maybe @lubronzhan could cut a release? |
|
@rizzza Sure, I fixed this PR. |
| skip-pkg-cache: true | ||
| skip-build-cache: true |
There was a problem hiding this comment.
Thanks for the PR, @masap . I'm assuming the lint errors are due to this change here?
There was a problem hiding this comment.
I'm assuming the lint errors are due to this change here?
No, we need this change to fix trailing warning.
Warning: Unexpected input(s) 'skip-pkg-cache', 'skip-build-cache', valid inputs are ['version', 'install-mode', 'working-directory', 'github-token', 'verify', 'only-new-issues', 'skip-cache', 'skip-save-cache', 'problem-matchers', 'args', 'cache-invalidation-interval']
There was a problem hiding this comment.
Ack, would you be able to resolve the lint errors?
There was a problem hiding this comment.
@ShashankGirish I fixed the lint errors.
There was a problem hiding this comment.
And fixed some additional CVEs.
7379ead to
ec9717b
Compare
f862db8 to
5568eaa
Compare
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
/bin/sh: 1: F: not found golangci-lint run --out-format=github-actions --timeout=5m0s -v: command not found Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
|
CI Test/integration-test-on-kind failed with this error
This happens after upgrading go version to 1.24.9. |
@jerrychengca Thank you, I picked it up. |
…rackets. Fixed by: @jerrychengca Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
What this PR does / why we need it:
This PR fixes some vulnerabilities found by
Trivy.Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: