Add additional generic components and helpers#224
Merged
Conversation
anujc25
commented
Jan 21, 2025
anujc25
force-pushed
the
add-plugin-helper
branch
from
9314b92 to
81995d3
Compare
anujc25
force-pushed
the
add-plugin-helper
branch
from
81995d3 to
5a47482
Compare
anujc25
commented
Jan 23, 2025
anujc25
commented
Feb 1, 2025
Comment on lines
+13
to
+20
| var ( | ||
| FaintColor = color.New(color.Faint) | ||
| InfoColor = color.New(color.FgCyan) | ||
| SuccessColor = color.New(color.FgGreen) | ||
| WarnColor = color.New(color.FgYellow) | ||
| ErrorColor = color.New(color.FgRed) | ||
| BoldColor = color.New(color.Bold) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Noticed that we already have compnent/colorable-tty.go which holds similar color specific helpers. Check to see how we can combine both.
Contributor
Author
There was a problem hiding this comment.
I have deprecated some of the string helpers in colorable-tty.go and created a new package stringutils which includes all the string specific utils functions along with color specific helpers.
anujc25
commented
Feb 3, 2025
anujc25
force-pushed
the
add-plugin-helper
branch
from
70bfe9c to
b6d6e7a
Compare
marckhouzam
reviewed
Feb 4, 2025
Contributor
marckhouzam
left a comment
marckhouzam
left a comment
There was a problem hiding this comment.
Nice stuff.
Thanks for the effort!
anujc25
force-pushed
the
add-plugin-helper
branch
2 times, most recently
from
3fc5814 to
4fae43f
Compare
anujc25
force-pushed
the
add-plugin-helper
branch
from
4fae43f to
26ad5bc
Compare
marckhouzam
reviewed
Feb 4, 2025
marckhouzam
approved these changes
Feb 4, 2025
Contributor
marckhouzam
left a comment
marckhouzam
left a comment
There was a problem hiding this comment.
LGTM
Very nice.
If there are things to tweak when we start using this change in an existing plugin, we can fix in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add additional generic components and helpers functions
Arg,ErrorandExtendhelpers undercommandpackagecomponent/iconspackagecomponent/stringutilspackagecomponent/tabwriterpackageWhich issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer