Merged
Conversation
marckhouzam
force-pushed
the
marck/cobra1.9.1
branch
from
44e67d0 to
fea1097
Compare
prkalle
reviewed
Feb 18, 2025
Contributor
prkalle
left a comment
prkalle
left a comment
There was a problem hiding this comment.
The change LGTM. Good to go after CI passed
marckhouzam
force-pushed
the
marck/cobra1.9.1
branch
from
fea1097 to
7f4b8ea
Compare
Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
marckhouzam
force-pushed
the
marck/cobra1.9.1
branch
from
7f4b8ea to
45c1574
Compare
prkalle
approved these changes
Feb 19, 2025
Contributor
prkalle
left a comment
prkalle
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Upgrade to Cobra 1.9.1
Which issue(s) this PR fixes
Fixes # N/A
Describe testing done for PR
Let CI run
Release note
Additional information
Special notes for your reviewer