Skip to content

enable the BSL service account to be used for requests#252

Open
s3than wants to merge 1 commit intovmware-tanzu:mainfrom
s3than:downloadrequest-federation-json
Open

enable the BSL service account to be used for requests#252
s3than wants to merge 1 commit intovmware-tanzu:mainfrom
s3than:downloadrequest-federation-json

Conversation

@s3than
Copy link
Copy Markdown

@s3than s3than commented Mar 27, 2026

When GOOGLE_APPLICATION_CREDENTIALS points to a federation.json (external_account credentials), the Init() method detected the credential type but had no handling for it — falling through without setting googleAccessID. The initFromComputeEngine path (which reads serviceAccount from BSL config) was only reachable when no credentials file was present.

This adds external_account as an explicit case in the credential type switch, calling initFromComputeEngine to read serviceAccount from BSL config and set up IAM-based signing. This unblocks DownloadRequest operations (e.g. velero describe --details) for clusters using the federation webhook.

Signed-off-by: Tim Colbert <s3than@users.noreply.github.com>
@s3than s3than force-pushed the downloadrequest-federation-json branch from e5e40cd to 534063b Compare March 27, 2026 02:32
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.02%. Comparing base (d7c2024) to head (534063b).

Files with missing lines Patch % Lines
velero-plugin-for-gcp/object_store.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   27.53%   28.02%   +0.48%     
==========================================
  Files           4        4              
  Lines         443      446       +3     
==========================================
+ Hits          122      125       +3     
  Misses        309      309              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants