enable the BSL service account to be used for requests#252
Open
s3than wants to merge 1 commit intovmware-tanzu:mainfrom
Open
enable the BSL service account to be used for requests#252s3than wants to merge 1 commit intovmware-tanzu:mainfrom
s3than wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
Signed-off-by: Tim Colbert <s3than@users.noreply.github.com>
e5e40cd to
534063b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 27.53% 28.02% +0.48%
==========================================
Files 4 4
Lines 443 446 +3
==========================================
+ Hits 122 125 +3
Misses 309 309
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
GOOGLE_APPLICATION_CREDENTIALSpoints to afederation.json(external_account credentials), theInit()method detected the credential type but had no handling for it — falling through without settinggoogleAccessID. TheinitFromComputeEnginepath (which readsserviceAccountfrom BSL config) was only reachable when no credentials file was present.This adds
external_accountas an explicit case in the credential type switch, callinginitFromComputeEngineto readserviceAccountfrom BSL config and set up IAM-based signing. This unblocksDownloadRequestoperations (e.g.velero describe --details) for clusters using the federation webhook.