[9.1] [X-Port] bug: bump up govmomi to get the vappconfig fix#1485
Open
hpannem wants to merge 3 commits intovmware-tanzu:release/vc-9.1.0from
Open
[9.1] [X-Port] bug: bump up govmomi to get the vappconfig fix#1485hpannem wants to merge 3 commits intovmware-tanzu:release/vc-9.1.0from
hpannem wants to merge 3 commits intovmware-tanzu:release/vc-9.1.0from
Conversation
…u#1463) * Clear ProfileID for encrypted storage class VMIC copy (vmware-tanzu#1434) When later deploying the VM from the source VMIC, CopyVirtualDisk will not pass down the source keys to the host, so the copy will fail because the source cannot be read. So regardless if there is a default key provider, we have to clear the profile ID. The CL source is not encrypted, and the VM's actual disks will be encrypted during VM deployment. * Handle PVCs in crypto reconciler (vmware-tanzu#1460) When a PVC is specified in the VM Spec, CSI will not handle the crypto for that disk. Instead, VMOP must recrypt the disk if its encryption class changes. This is because the VM cannot mix key provider types. So if changing the key provider type of a disk, in that same reconfigure the VM's key provider must be also changed to one of that type. This is a late change and choices were made to reduce the scope and mostly confine the code changes into one place. There are many improvements that we'll need to make later. Co-authored-by: Bryan Venteicher <bryan.venteicher@broadcom.com> --------- Co-authored-by: Bryan Venteicher <bryanv@users.noreply.github.com> Co-authored-by: Bryan Venteicher <bryan.venteicher@broadcom.com>
Added a test to test vapp config props Fixed tests due to govmomi changes.
This PR updates the main root module as well as the api/test and hack/tools to use Go 1.24.13 version. This is required to fix the following CVE failing CI check: ``` Vulnerability #1: GO-2026-4337 Unexpected session resumption in crypto/tls More info: https://pkg.go.dev/vuln/GO-2026-4337 Standard library Found in: crypto/tls@go1.24.12 Fixed in: crypto/tls@go1.24.13 ```
Minimum allowed line rate is |
hpannem
changed the title
akutz
force-pushed
the
release/vc-9.1.0
branch
from
e94fe87 to
0a37553
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Added a test to test vapp config props
Fixed tests due to govmomi changes.
This is xport of
#1481, #1447
Bumped up go mod version 1.24.13 via this change since govmomi update requires it.
Triggered successful UTS pipeline.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):The PR fixes the creation of a VM with vApp properties using fast deploy. Also, bumps up go mod version t 24.13 from @dilyar85 PR.