🌱 Add per controller max reconciles knob#1487
Open
bryanv wants to merge 2 commits intovmware-tanzu:mainfrom
Open
🌱 Add per controller max reconciles knob#1487bryanv wants to merge 2 commits intovmware-tanzu:mainfrom
bryanv wants to merge 2 commits intovmware-tanzu:mainfrom
Conversation
We have a global MAX_CONCURRENT_RECONCILES env var that most
controllers use to set their number of workers, but the same
global value may not be appropriate controllers.
This allows changing the number of workers per controller, like
containers:
- args:
- --controller-max-concurrent-reconciles=virtualmachine-controller=40,virtualmachineservice-controller=25
command:
- /manager
Like their current behavior, pass in 0 for their default so they get the ctrl-runtime manger default of 1.
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Add per controller max reconciles knob
We have a global MAX_CONCURRENT_RECONCILES env var that most controllers use to set their number of workers, but the same global value may not be appropriate controllers.
This allows changing the number of workers per controller, like
Before:
With this change:
Example:
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
I didn't bother to plumb this through to the probe manager since that is basically deprecated.
Please add a release note if necessary: