🐛 fastDeploy directory cleanup (#1476)#1489
Open
zhangheliu wants to merge 3 commits intovmware-tanzu:release/vc-9.1.0from
Open
🐛 fastDeploy directory cleanup (#1476)#1489zhangheliu wants to merge 3 commits intovmware-tanzu:release/vc-9.1.0from
zhangheliu wants to merge 3 commits intovmware-tanzu:release/vc-9.1.0from
Conversation
…u#1463) * Clear ProfileID for encrypted storage class VMIC copy (vmware-tanzu#1434) When later deploying the VM from the source VMIC, CopyVirtualDisk will not pass down the source keys to the host, so the copy will fail because the source cannot be read. So regardless if there is a default key provider, we have to clear the profile ID. The CL source is not encrypted, and the VM's actual disks will be encrypted during VM deployment. * Handle PVCs in crypto reconciler (vmware-tanzu#1460) When a PVC is specified in the VM Spec, CSI will not handle the crypto for that disk. Instead, VMOP must recrypt the disk if its encryption class changes. This is because the VM cannot mix key provider types. So if changing the key provider type of a disk, in that same reconfigure the VM's key provider must be also changed to one of that type. This is a late change and choices were made to reduce the scope and mostly confine the code changes into one place. There are many improvements that we'll need to make later. Co-authored-by: Bryan Venteicher <bryan.venteicher@broadcom.com> --------- Co-authored-by: Bryan Venteicher <bryanv@users.noreply.github.com> Co-authored-by: Bryan Venteicher <bryan.venteicher@broadcom.com>
…1486) * Exit pod if capabilities cannot be loaded at startup (vmware-tanzu#1474) This ensures the pod does not start with incorrect capabilities. * Remove duplicated UTs for UpdateCapabilities (vmware-tanzu#1479) Removed UTs are already covered by other tests.
Move defer cleanup registration immediately after directory creation for better error handling. Fix cleanup for non-empty directories on non-TLD datastores by using DeleteDatastoreFile() first, then DeleteDirectory() to clean up namespace mapping.
Minimum allowed line rate is |
akutz
force-pushed
the
release/vc-9.1.0
branch
from
e94fe87 to
0a37553
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This PR is to x-port #1476 to 9.1
Move defer cleanup registration immediately after directory creation for better error handling. Fix cleanup for non-empty directories on non-TLD datastores by using DeleteDatastoreFile() first, then DeleteDirectory() to clean up namespace mapping.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: