Open
Conversation
bryanv
force-pushed
the
bryanv/remove-global-log-var
branch
3 times, most recently
from
2a613cd to
adac3ba
Compare
github-actions
bot
added
size/L
hpannem
reviewed
Mar 3, 2026
Contributor
There was a problem hiding this comment.
May be we could use logger via context, instead of passing. Creating a new logger context
We may need to add a new function in the pkglog and we can remove reference to logr in this file?
ctx = logr.NewContext(ctx, logger)
bryanv
force-pushed
the
bryanv/remove-global-log-var
branch
from
adac3ba to
8719b92
Compare
This should fix the error: stderr F [controller-runtime] log.SetLogger(...) was never called; logs will not be displayed. ... stderr F > github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config.init() stderr F > /build/.../vm-operator/src/pkg/providers/vsphere/config/config.go:23 +0x34
bryanv
force-pushed
the
bryanv/remove-global-log-var
branch
from
8719b92 to
d8b1063
Compare
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This should fix the error:
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: