🌱 Relax ContentLibrary type check for async quota#1518
Open
abaruni wants to merge 1 commit intovmware-tanzu:mainfrom
Open
🌱 Relax ContentLibrary type check for async quota#1518abaruni wants to merge 1 commit intovmware-tanzu:mainfrom
abaruni wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
This PR relaxes the type (ContentLibrary, Inventory) that is done before initiating async quota validation. Async quota validation is no longer reserved solely for Inventory type ContentLibrary.
bryanv
reviewed
Mar 20, 2026
| } | ||
|
|
||
| // Check if quota validation is needed | ||
| if metav1.HasLabel(ctx.ContentLibraryV1A2.ObjectMeta, pkgconst.AsyncQuotaPerformCheckAnnotationKey) { |
Contributor
There was a problem hiding this comment.
I know it what's was there before but is the Async...AnnotationKey name just a typo, or something like used in both annotations and labels?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This PR relaxes the type (ContentLibrary, Inventory) that is done before initiating async quota validation. Async quota validation is no longer reserved solely for Inventory type ContentLibrary.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: