Honor stderrthreshold when logtostderr is enabled#1539
Open
pierluigilenoci wants to merge 1 commit intovmware-tanzu:mainfrom
Open
Honor stderrthreshold when logtostderr is enabled#1539pierluigilenoci wants to merge 1 commit intovmware-tanzu:mainfrom
pierluigilenoci wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
pierluigilenoci
requested review from
akutz,
aruneshpa and
bryanv
as code owners
Author
Author
Collaborator
|
Thank you so much for this! I am going to approve it, but could you please rebase on |
akutz
requested changes
Apr 15, 2026
Collaborator
akutz
left a comment
akutz
left a comment
There was a problem hiding this comment.
Please rebase on main instead of merging main into the PR.
Minimum allowed line rate is |
Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
pierluigilenoci
force-pushed
the
fix/honor-stderrthreshold
branch
from
83350e9 to
5941506
Compare
Author
|
@akutz Done! Rebased onto latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
klog's legacy behavior silently drops the
--stderrthresholdflag when--logtostderris enabled (the default). This means users who set--stderrthreshold=ERRORexpecting to reduce stderr noise still get every log line on stderr.This PR opts into the fixed behavior introduced in kubernetes/klog#432 by setting:
after
klog.InitFlags()and beforeflag.Parse(), so that--stderrthresholdis actually honored.The klog/v2 dependency is bumped from v2.130.1 to v2.140.0 (minimum version that includes the fix).
References:
Changes
cmd/web-console-validator/main.go: add stderrthreshold opt-in afterklog.InitFlags()go.mod/go.sum: bumpk8s.io/klog/v2to v2.140.0/cc @bryanv @akutz @dilyar85