Skip to content

[Linux] Get installed open-vm-tools packages before uninstalling #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

keirazhang
Copy link
Contributor

openSUSE 16.0 Beta release doesn't have open-vm-tools-desktop installed as it has no desktop. To avoid uninstalling non-existing package, this fix filtered out installed open-vm-tools packages, and then uninstall them.

+---------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                      |
|                           | bitness='64'                            |
|                           | cpeString='cpe:/o:opensuse:leap:16.0'   |
|                           | distroAddlVersion='16.0 Beta'           |
|                           | distroName='openSUSE Leap'              |
|                           | distroVersion='16.0'                    |
|                           | familyName='Linux'                      |
|                           | kernelVersion='6.12.0-160000.9-default' |
|                           | prettyName='openSUSE Leap 16.0 Beta'    |
+---------------------------------------------------------------------+

Test Results (Total: 1, Passed: 1, Elapsed Time: 00:08:56)
+--------------------------------------------------+
| ID | Name                   | Status | Exec Time |
+--------------------------------------------------+
|  1 | ovt_verify_pkg_install | Passed | 00:08:35  |
+--------------------------------------------------+

@keirazhang keirazhang requested a review from Tomorrow9 May 7, 2025 03:27
@keirazhang keirazhang added this to the 3.3 milestone May 7, 2025
@Tomorrow9
Copy link
Member

ovt_packages list contains open-vm-tools-desktop when guest_os_with_gui, so here openSUSE 16.0 Beta release without desktop but getting parameter guest_os_with_gui to be set to True?

@keirazhang
Copy link
Contributor Author

ovt_packages list contains open-vm-tools-desktop when guest_os_with_gui, so here openSUSE 16.0 Beta release without desktop but getting parameter guest_os_with_gui to be set to True?

We check whether display-manager.service is running to decide guest OS has GUI or not. At present, openSUSE 16 has this service running but its desktop is not ready yet. So it added open-vm-tools-desktop into OVT package list.

@keirazhang keirazhang force-pushed the fix_opensuse16_ovt branch from c65fe1d to 681f330 Compare May 7, 2025 07:39
@Tomorrow9
Copy link
Member

We check whether display-manager.service is running to decide guest OS has GUI or not. At present, openSUSE 16 has this service running but its desktop is not ready yet. So it added open-vm-tools-desktop into OVT package list.

Then the problem is setting parameter guest_os_with_gui according to the real situation.

@keirazhang keirazhang force-pushed the fix_opensuse16_ovt branch from a2560dc to 681f330 Compare May 9, 2025 06:09
@keirazhang
Copy link
Contributor Author

Then the problem is setting parameter guest_os_with_gui according to the real situation.

The desktop issue would cause ovt_verify_status failure, and I will create another pull requests to update desktop detection by checking login session.

Uninstalled packages should not block the testing. We only need to uninstall whatever it is installed in the guest OS.

Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit f4e933b into vmware:main May 9, 2025
@keirazhang keirazhang deleted the fix_opensuse16_ovt branch May 9, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants