Skip to content

[artifact-manager] (#1016) Fix Refresh token push and pull for vra-ng #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VenelinBakalov merged 3 commits into from
Feb 6, 2026
Merged

[artifact-manager] (#1016) Fix Refresh token push and pull for vra-ng #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ca7014
Fix push pull with refresh token only #1016
Feb 6, 2026
558166e
Remove sensitive data from the logs
Feb 6, 2026
d16a5b5
Add a release note
Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../java/com/vmware/pscoe/iac/artifact/aria/orchestrator/configuration/ConfigurationVro.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public void validate(boolean domainOptional) throws ConfigurationException {
logger.info("Checking if exists refresh token");
boolean useRefreshTokenForAuth = !StringUtils.isEmpty(this.getRefreshToken());
if (useRefreshTokenForAuth) {
logger.info(String.format("Refresh token in config for vro is: %s", this.getRefreshToken()));
logger.info("Refresh token detected and using Token Authentication");
} else {
logger.info("Refresh token not detected using BASIC Authentication");
super.validate(domainOptional, useRefreshTokenForAuth);
Expand Down
2 changes: 1 addition & 1 deletion ...nager/src/main/java/com/vmware/pscoe/iac/artifact/common/configuration/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public abstract class Configuration {
/**
* Contains all the properties passed by the user.
*/
protected Properties properties;
public final Properties properties;

/**
* Logger instance.
Expand Down
10 changes: 1 addition & 9 deletions ...ct-manager/src/main/java/com/vmware/pscoe/iac/artifact/common/rest/RestClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,15 +250,7 @@ public void handleError(URI url, HttpMethod method, ClientHttpResponse response)
}

private static String getVraApiVersion(Configuration configuration, RestTemplate restTemplate) {
Properties properties = new Properties();

properties.setProperty(Configuration.USERNAME, configuration.getUsername());
properties.setProperty(Configuration.PASSWORD, configuration.getPassword());
properties.setProperty(Configuration.PORT, configuration.getPort() + "");
properties.setProperty(Configuration.HOST, configuration.getHost());

ConfigurationVro configurationVro = ConfigurationVro.fromProperties(properties);

ConfigurationVro configurationVro = ConfigurationVro.fromProperties(configuration.properties);
VraSsoAuth vraClient = new VraSsoAuth(configurationVro, restTemplate);
return vraClient.getVersion();
}
Expand Down
12 changes: 12 additions & 0 deletions docs/versions/latest/Release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@ Pushing AlertDefinitions with `alertConditions` fails as the ID is not being cle

#### New Behavior
`alertConditions` ID is set to null before pushing AlertDefinitions with `alertDefinitions` and the operation completes successfully.

### *Fix Push and Pull with refresh token only*

#### Previous Behavior
Push and pull operations failed with a `NullPointerException` when authenticating using only a refresh token:
```text
Execution default-cli of goal com.vmware.pscoe.maven.plugins:vra-ng-package-maven-plugin:4.16.1:pull failed.: NullPointerException
```

#### New Behavior
Push and pull operations now complete successfully when using a refresh token. Additionally, sensitive token values are now automatically redacted from the execution logs.

## Upgrade procedure

### *Add missing dependency to `o11n-plugin-aria` type definitions and fix static methods*
Expand Down
Loading