Skip to content

[artifact-manager] (#669) Fix failure during pull of vROPs Policies #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

akantchev
Copy link
Contributor

@akantchev akantchev commented Mar 27, 2025

[maven, vrops] (#669) Fixed Problem with Pulling of vROPs Policies.

Description

Fixed problem with pulling of vROPs policies due to missing policiesMetadata.vrops.json file during pull. The manipulation of this file is removed, as it is no longer needed.
When exporting of special type custom groups (dependent on vROPs policies), the name of the policy is stored in the custom group JSON file. When importing those custom groups to vROPs their policies are searched in the target system prior import, if they cannot be found an error will be thrown.

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Using a project generated by the vROPs archetype that has policies in the content.yaml do:

mvn vrops:pull -P <ENV_NAME>

Pull should be working fine.

Release Notes

When exporting of special type custom groups (dependent on vROPs policies), the name of the policy is stored in the custom group JSON file. When importing those custom groups to vROPs their policies are searched in the target system prior import, if they cannot be found an error will be thrown.

Related issues and PRs

#669

…metadata file, added smart handling of custom groups that depend on policies.

Signed-off-by: Alexander Kantchev <[email protected]>
@akantchev akantchev added kind/bug Something isn't working lang/java Related to Java Code version/minor Introduces a non-breaking feature or change area/maven Relates to maven changes labels Mar 27, 2025
@akantchev akantchev self-assigned this Mar 27, 2025
@akantchev akantchev requested a review from a team as a code owner March 27, 2025 13:41
Signed-off-by: Alexander Kantchev <[email protected]>
@VenelinBakalov VenelinBakalov changed the title [maven, vrops] (#669) Fixed Problem with Pulling of vROPs Policies [artifact-manager] (#669) Fixed Problem with Pulling of vROPs Policies Mar 28, 2025
@VenelinBakalov VenelinBakalov changed the title [artifact-manager] (#669) Fixed Problem with Pulling of vROPs Policies [artifact-manager] (#669) Fix failure during pull of vROPs Policies Mar 28, 2025
@VenelinBakalov VenelinBakalov added area/artifact-manager Relates to the `artifact-manager` maven module version/patch The change is a non-breaking bugfix and removed area/maven Relates to maven changes version/minor Introduces a non-breaking feature or change labels Mar 28, 2025
Signed-off-by: Alexander Kantchev <[email protected]>
Alexander Kantchev added 4 commits April 7, 2025 12:54
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
@akantchev akantchev requested a review from marteca April 10, 2025 10:19
Signed-off-by: Alexander Kantchev <[email protected]>
@akantchev akantchev linked an issue Apr 14, 2025 that may be closed by this pull request
Signed-off-by: Alexander Kantchev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifact-manager Relates to the `artifact-manager` maven module kind/bug Something isn't working lang/java Related to Java Code version/patch The change is a non-breaking bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vrops:pull fails to pull policies
3 participants