-
Notifications
You must be signed in to change notification settings - Fork 26
[artifact-manager] (#669) Fix failure during pull of vROPs Policies
#678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akantchev
wants to merge
9
commits into
main
Choose a base branch
from
fix/669-vrops-pull-policy-failure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metadata file, added smart handling of custom groups that depend on policies. Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
vROPs Policies
Signed-off-by: Alexander Kantchev <[email protected]>
...ger/src/main/java/com/vmware/pscoe/iac/artifact/aria/operations/store/VropsPackageStore.java
Dismissed
Show dismissed
Hide dismissed
marteca
reviewed
Apr 3, 2025
...r/src/main/java/com/vmware/pscoe/iac/artifact/aria/operations/models/CustomGroupTypeDTO.java
Show resolved
Hide resolved
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
Signed-off-by: Alexander Kantchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/artifact-manager
Relates to the `artifact-manager` maven module
kind/bug
Something isn't working
lang/java
Related to Java Code
version/patch
The change is a non-breaking bugfix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[maven, vrops] (#669) Fixed Problem with Pulling of vROPs Policies.
Description
Fixed problem with pulling of vROPs policies due to missing policiesMetadata.vrops.json file during pull. The manipulation of this file is removed, as it is no longer needed.
When exporting of special type custom groups (dependent on vROPs policies), the name of the policy is stored in the custom group JSON file. When importing those custom groups to vROPs their policies are searched in the target system prior import, if they cannot be found an error will be thrown.
Checklist
Fixed #XXX -
orClosed #XXX -
prefix to auto-close the issueTesting
Using a project generated by the vROPs archetype that has policies in the content.yaml do:
Pull should be working fine.
Release Notes
When exporting of special type custom groups (dependent on vROPs policies), the name of the policy is stored in the custom group JSON file. When importing those custom groups to vROPs their policies are searched in the target system prior import, if they cannot be found an error will be thrown.
Related issues and PRs
#669