Skip to content

[vrotest] (#695) Dependencies causing errors during build #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[vrotest] (#695) Dependencies causing errors during build #702

wants to merge 7 commits into from

Conversation

bcpmihail
Copy link
Contributor

Description

Fixed errors related to dependency versions shown when running vrotest.

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Tested by building BTVA with the fix

Release Notes

Related issues and PRs

#695

@bcpmihail bcpmihail added kind/bug Something isn't working version/patch The change is a non-breaking bugfix area/tests Relates to tests and code coverage labels Apr 14, 2025
@bcpmihail bcpmihail self-assigned this Apr 14, 2025
@bcpmihail bcpmihail requested a review from a team as a code owner April 14, 2025 09:15
@bcpmihail bcpmihail linked an issue Apr 14, 2025 that may be closed by this pull request
Dependencies causing errors during build #695
Open
@github-actions github-actions bot added the kind/dependencies Pull requests that update a dependency file label Apr 14, 2025
@Indy-rbo
Copy link
Contributor

Indy-rbo commented Apr 14, 2025 •
edited
Loading

While upgrading the dependencies is probably a good idea. I don't think you should delete/ignore the package-lock.json as a whole.

According to the docs on npm (here), the package-lock is "... is intended to be committed into source repositories...", as it "It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates."

This file is useful so that that teammates, deployments, and continuous integration are guaranteed to install exactly the same dependencies.

Of course feel free to ignore, but I'd advise against doing this

@bcpmihail bcpmihail force-pushed the bugfix/695-dependencies-causing-errors-during-build branch from a5240c0 to 1655ba1 Compare April 14, 2025 11:34
@bcpmihail
Copy link
Contributor Author

While upgrading the dependencies is probably a good idea. I don't think you should delete/ignore the package-lock.json as a whole.

According to the docs on npm (here), the package-lock is "... is intended to be committed into source repositories...", as it "It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates."

This file is useful so that that teammates, deployments, and continuous integration are guaranteed to install exactly the same dependencies.

Of course feel free to ignore, but I'd advise against doing this

I've restored the package-lock files and only updated the version of jasmine.

@bcpmihail bcpmihail force-pushed the bugfix/695-dependencies-causing-errors-during-build branch from 8f2e4d6 to 15bc7db Compare April 15, 2025 14:42
@bcpmihail
feat: edited vropkg Gulpfile to remove gulp-jasmine dependency
31eed8f 
It was causing an error for newer jasmine versions

Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
feat: updated package.json files:
aa0fdd8 
Updated jasmine to 5.6.0 to support latest glob
Using glob 11.0.1
Forced vinyl-fs to newest version to use latest glob
Removed gulp-jasmine

Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
docs: updated release.md
e4511de 
Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
chore: updated tsconfig.tsbuildinfo
9cb35a4 
Using ts version 5.8.3

Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
feat: updated package-lock.json in polyglotpkg, vropkg
a1c4e0d 
Using latest supported dependency versions.

Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail bcpmihail force-pushed the bugfix/695-dependencies-causing-errors-during-build branch from 15bc7db to a1c4e0d Compare April 15, 2025 15:38
@bcpmihail
WIP: updated package-lock.json for vrotsc, npmconv, vrotest, vro-scri…
7f1e6c9 
…pting-api

Failing on vrotsc with error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies...

Signed-off-by: Mihail Penchev (c) <[email protected]>
@bcpmihail
WIP further package and package-lock.json versions changed
7a60cdd 
Signed-off-by: Mihail Penchev (c) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bcpmihail bcpmihail

Labels
area/tests Relates to tests and code coverage kind/bug Something isn't working kind/dependencies Pull requests that update a dependency file version/patch The change is a non-breaking bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies causing errors during build
2 participants
@bcpmihail @Indy-rbo