[artifact-manager] (#898) Fix push of vROps policies by stanislav-skkolev-spec · Pull Request #911 · vmware/build-tools-for-vmware-aria

stanislav-skkolev-spec · 2025-10-23T09:11:17Z

Description

Fix for failing to push policies for vROps. Implemented functionallity of each policy .xml to check for missing alerts, symptoms and recommendations on the target server.

Checklist

[ x] I have added relevant error handling and logging messages to help troubleshooting
I have added tests that prove my fix is effective or that my feature works
[ x] I have added necessary documentation, relevant usage information (if applicable)
[ x] I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
I have added labels for implementation kind (kind/) and version type (version/)
[ x] I have tested against live environment, if applicable
I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Tested with complex policies on both local and client environment.

Release Notes

Fixes #898

merge with main

...anager/src/main/java/com/vmware/pscoe/iac/artifact/aria/operations/rest/RestClientVrops.java

VenelinBakalov · 2025-10-24T07:50:58Z

...ger/src/main/java/com/vmware/pscoe/iac/artifact/aria/operations/store/VropsPackageStore.java

+                Element policyElement = policyElements.get(i);
+				String policyName = policyElement.getAttribute("name");
+				HashMap<String, String> childMap = new HashMap<>();
+                Optional<Policy> currentPolicy = allPolicies.stream().filter(pol -> pol.getName().equals(policyElement.getAttribute("name"))).findAny();


What amount of policies do we expect here? I am wondering if it makes sense to convert this to a map and use the name or id for key so we can reduce the filtering operations in case we expect a big list.

What amount of policies do we expect here? I am wondering if it makes sense to convert this to a map and use the name or id for key so we can reduce the filtering operations in case we expect a big list.

From what I have saw they are not that many.

Map also would make sure no duplicate policy ids are present in the zip.

VenelinBakalov · 2025-10-24T07:56:40Z

...ger/src/main/java/com/vmware/pscoe/iac/artifact/aria/operations/store/VropsPackageStore.java

 	 */
 	private void importPolicies(final Package vropsPackage, final File tmpDir) {
+
+		List<AlertDefinition> alertDefinitions = restClient.getAlltDefinitionsOfType(VropsPackageMemberType.ALERT_DEFINITION)


Minor thing but there is a "t" beteween All and Definitions in this functions and the ones belows

VenelinBakalov · 2025-10-24T07:59:48Z

.../artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/common/utils/ZipUtilities.java

+             ZipOutputStream zos = new ZipOutputStream(fos);
+             FileInputStream fis = new FileInputStream(file.getPath())) {
+
+            ZipEntry zipEntry = new ZipEntry(new File(file.getPath()).getName());


While do we need to create a new File() here from the file input?

fixed some cosmetic errors

.../artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/common/utils/XmlUtilities.java

VenelinBakalov

Pending discussion after further discoveries

github-actions · 2026-01-29T02:17:01Z

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

stanislavk added 6 commits October 10, 2025 15:43

initial preparations

3286b72

added XmlUtilities

24fca7a

prepared for testing on customer env

43035cc

added check for missing policies dependencies

de6c36a

comparison improved

9000729

Merge branch 'main' into fix/898-push-vrops-policies

52e1cbe

merge with main

stanislav-skkolev-spec requested a review from a team as a code owner October 23, 2025 09:11

github-actions bot added the kind/bug Something isn't working label Oct 23, 2025

stanislavk added 2 commits October 23, 2025 12:25

fixed Linter suggestions

ced0f15

fixed Linter errors

5007320

VenelinBakalov changed the title ~~Fix/898 push vrops policies~~ (#898) push vrops policies Oct 23, 2025

VenelinBakalov changed the title ~~(#898) push vrops policies~~ [artifact-manager] (#898) push vrops policies Oct 23, 2025

VenelinBakalov changed the title ~~[artifact-manager] (#898) push vrops policies~~ [artifact-manager] (#898) Fix push of vROps policies Oct 23, 2025

stanislavk added 2 commits October 23, 2025 15:01

added Readme.md

16f05fa

fixed linter errors

eac90fc

VenelinBakalov reviewed Oct 24, 2025

View reviewed changes

...anager/src/main/java/com/vmware/pscoe/iac/artifact/aria/operations/rest/RestClientVrops.java Outdated Show resolved Hide resolved

VenelinBakalov reviewed Oct 24, 2025

View reviewed changes

removed 4.15.0 folder

0fddd50

fixed some cosmetic errors

VenelinBakalov added lang/java Related to Java Code area/artifact-manager Relates to the `artifact-manager` maven module version/patch The change is a non-breaking bugfix labels Oct 24, 2025

VenelinBakalov reviewed Oct 24, 2025

View reviewed changes

.../artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/common/utils/XmlUtilities.java Show resolved Hide resolved

joroaf approved these changes Oct 24, 2025

View reviewed changes

stanislavk and others added 2 commits October 24, 2025 14:40

added Javadocs + minor fixes

2310f21

Merge branch 'main' into fix/898-push-vrops-policies

0b1a576

joroaf approved these changes Nov 24, 2025

View reviewed changes

VenelinBakalov requested changes Nov 24, 2025

View reviewed changes

github-actions bot added the Stale label Dec 25, 2025

vmware deleted a comment from github-actions bot Dec 29, 2025

VenelinBakalov removed the Stale label Dec 29, 2025

github-actions bot added the Stale label Jan 29, 2026

VenelinBakalov removed the Stale label Jan 29, 2026

VenelinBakalov added the triage/blocked This issue is blocked by another, specified in the description label Feb 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[artifact-manager] (#898) Fix push of vROps policies#911

[artifact-manager] (#898) Fix push of vROps policies#911
stanislav-skkolev-spec wants to merge 13 commits intomainfrom
fix/898-push-vrops-policies

stanislav-skkolev-spec commented Oct 23, 2025 •

edited by VenelinBakalov

Loading

Uh oh!

Uh oh!

VenelinBakalov Oct 24, 2025

Uh oh!

stanislav-skkolev-spec Oct 24, 2025

Uh oh!

akantchev Oct 28, 2025

Uh oh!

VenelinBakalov Oct 24, 2025

Uh oh!

VenelinBakalov Oct 24, 2025

Uh oh!

Uh oh!

VenelinBakalov left a comment

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

stanislav-skkolev-spec commented Oct 23, 2025 • edited by VenelinBakalov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Testing

Release Notes

Uh oh!

Uh oh!

VenelinBakalov Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

stanislav-skkolev-spec Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

akantchev Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

VenelinBakalov Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

VenelinBakalov Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VenelinBakalov left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stanislav-skkolev-spec commented Oct 23, 2025 •

edited by VenelinBakalov

Loading