Skip to content

fix: add missing keys to Helm values file#1182

Open
alex1989hu wants to merge 1 commit intovmware:master-oldfrom
alex1989hu:fix/add-missing-keys-to-helm-values
Open

fix: add missing keys to Helm values file#1182
alex1989hu wants to merge 1 commit intovmware:master-oldfrom
alex1989hu:fix/add-missing-keys-to-helm-values

Conversation

@alex1989hu
Copy link

These keys were removed in 2d8141a but the templating options were partially kept.

Having these keys will give option to users to override fields of the StatefulSet

The default value of affinity is copied from 9fef184

These keys were removed in 2d8141a but the templating
options were partially kept.

Having these keys will give option to users to override fields
of the StatefulSet

The default value of affinity is copied from 9fef184

Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@akshayhavile
Copy link
Contributor

Can one of the admins verify this patch?

tolerations: []

affinity:
podAntiAffinity:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshayhavile should we give the user the ability to change the affinity rules?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @swathinsankaran in my use case I need to schedule AKO to specific worker nodes by setting conditions in affinity rule (e.g. egress firewall policy to the Avi controller)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex1989hu. We will plan to include this in the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants