Changed AVIInfraSettingCR Name #1727
Open
+60
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Rishabh-Baranwal
force-pushed
the
BZ-3508026
branch
from
e02c56a to
6a10ec9
Compare
| project := strings.Split(arr[0], "/projects/")[1] | ||
| tenant, err := getTenantForProject(project) | ||
| projectArr := strings.Split(arr[0], "/projects/") | ||
| infraSettingName := lib.GetAviInfraSettingName(projectArr[len(projectArr)-1] + arr[len(arr)-1]) |
There was a problem hiding this comment.
let's put a delimiter between project name and vpc name, for ex - project + "-" + vpc
abhishekbsingh
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : VPC with name "VPC-foo" gets used as name for AVIInfraSetting CR which is not DNS compliant. As a result, AVIInfraSetting CR won't get created.
Fix : Create hash of project name and vpc name, and use it as AVIInfraSetting CR name.
For parity, same change has been done in case of T1 based WCP environment.