Skip to content

AV-228166 Relax subnet validation check for EKS deployments #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

srinivassurishetty
Copy link
Collaborator

@srinivassurishetty srinivassurishetty commented Apr 16, 2025

			// During the portal-webapp migration from Python to Go, network views were not correctly ported. However, network APIs are now being routed through Go code,
			// which is incorrect. The Avi Controller needs to be fixed.
			// For now, disabling the subnet UUID validation for AWS to avoid impact on EKS deployments.

EKS tests have been passed after this change.

16:50:41 functional/ako/test_multivip.py::TestMultiVipSNI::test_create_ingress PASSED [  5%]
16:51:45 functional/ako/test_multivip.py::TestMultiVipSNI::test_update_to_multivip_ingress PASSED [ 10%]
16:53:07 functional/ako/test_multivip.py::TestMultiVipSNI::test_update_to_single_vip_ingress PASSED [ 15%]
16:53:54 functional/ako/test_multivip.py::TestMultiVipSNI::test_create_l4 PASSED  [ 20%]
16:54:20 functional/ako/test_multivip.py::TestMultiVipSNI::test_update_to_multivip_l4 PASSED [ 25%]
16:55:07 functional/ako/test_multivip.py::TestMultiVipSNI::test_update_to_single_vip_l4 PASSED [ 30%]
16:55:55 functional/ako/test_multivip.py::TestMultiVipSNI::test_create_ingress_class PASSED [ 35%]
16:56:29 functional/ako/test_multivip.py::TestMultiVipSNI::test_update_to_multivip_ingress_class PASSED [ 40%]
17:01:47 functional/ako/test_multivip.py::TestMultiVipSNI::test_status_update_ingress PASSED [ 45%]

@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@avijenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@srinivassurishetty srinivassurishetty marked this pull request as draft April 16, 2025 09:27
@srinivassurishetty srinivassurishetty changed the title Relax subnet validation check for EKS deployments AV-228166 Relax subnet validation check for EKS deployments Apr 16, 2025
@srinivassurishetty srinivassurishetty force-pushed the fix-eks-network-validation-check branch 2 times, most recently from f600f28 to fe53134 Compare April 21, 2025 17:41
@srinivassurishetty srinivassurishetty force-pushed the fix-eks-network-validation-check branch from fe53134 to cdd1914 Compare April 21, 2025 17:42
@srinivassurishetty srinivassurishetty self-assigned this Apr 22, 2025
@srinivassurishetty srinivassurishetty marked this pull request as ready for review April 22, 2025 11:38
@akshayhavile
Copy link
Contributor

build ako

Copy link
Contributor

@arihantg arihantg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arihantg arihantg merged commit 73bfecc into master Apr 23, 2025
7 checks passed
srinivassurishetty pushed a commit that referenced this pull request Apr 24, 2025
AV-228166 Relax subnet validation check for EKS deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants