Skip to content

Conversation

@sestegra
Copy link

Use recommanded labels as described in Helm official documentation
https://helm.sh/docs/chart_best_practices/labels/#standard-labels

This implementation fixes an issue on ClusterRoleBinding as the following
The following labels definition must be guarded by | replace "+" "_"

The following definition

  labels:
    chart: {{ .Chart.Name }}-{{ .Chart.Version }}

must be replaced by

  labels:
    helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}.

Then, as this notation already exists in the _helpers.tpl.file, it can be changed to

  labels:
    {{- include "ako.labels" . | nindent 4 }}

Signed-off-by: Stéphane Este-Gracias <[email protected]>
@avijenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@gurunath-avi gurunath-avi changed the base branch from master-old to master October 22, 2025 12:51
@avijenkins
Copy link
Collaborator

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants