AV-252538: Add documentation for dedicated gateway mode#1953
Open
ashishnayak96 wants to merge 1 commit intovmware:masterfrom
Open
AV-252538: Add documentation for dedicated gateway mode#1953ashishnayak96 wants to merge 1 commit intovmware:masterfrom
ashishnayak96 wants to merge 1 commit intovmware:masterfrom
Conversation
ashishnayak96
requested review from
DixitAakash,
akshayhavile,
arihantg and
pkoshtavmware
| ## Architecture | ||
|
|
||
| **Dedicated Gateway Mode:** | ||
| ``` |
Contributor
There was a problem hiding this comment.
Should we add one liner description here
|
|
||
| 1. **No Hostname in Listeners** | ||
| - Listener-level hostname specification is **NOT supported** | ||
| - Validation Error: `"Hostname is not supported in dedicated mode"` |
Contributor
There was a problem hiding this comment.
Not sure if line 63 and 64 is required. They look a bit odd. Instead of adding them in seperate lines, we can club them into single english sentence
|
|
||
| 2. **No Routes from All Namespaces** | ||
| - `allowedRoutes.namespaces.from: All` is **NOT supported** | ||
| - Validation Error: `"Routes from all namespaces is not supported in dedicated mode"` |
| - type: Exact | ||
| name: x-api-version | ||
| value: v1 | ||
| - type: Exact |
Contributor
There was a problem hiding this comment.
should this line be replaced with RegularExpression
| type: ReplaceFullPath | ||
| replaceFullPath: /v2/api | ||
| hostname: api.example.com | ||
| - type: RequestRedirect |
Contributor
There was a problem hiding this comment.
Do not think this is a valid config as requestRedirect cannot be used with URLRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.