Conversation
If the scripts directory contained a directory, for example __pycache__ it would try to execute it. This ensures that we only execute files.
|
@yunzheng, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@yunzheng, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@yunzheng, VMware has approved your signed contributor license agreement. |
|
Do you happen to have any updates to this PR? |
|
The changes from this pull request has already been incorporated and will be in the next major release of open-vm-tools. |
|
No I don’t have any updates. PR should still be applicable. @vmwkruti1111 good to know, was there a reason why the change was done outside this PR? |
|
Thanks again @yunzheng for your contribution, your patch has been accepted with additional modifications. |
|
Alright, thanks. happy to see it being fixed. PR can be closed then :) |
|
@yunzheng We will close this PR after the change shows up on "devel" branch and on the upcoming "stable-12.4.x" branch. Thanks again for your contribution. |
Adding a check to verify that the path to execute is a file only and not a directory. Pull request: #689
If the scripts directory contained a directory, for example pycache
it would try to execute it. This ensures that we only execute files.