Skip to content

fix: update Update-VcenterRootPasswordExpiration empty email handling #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

sowjuec
Copy link
Contributor

@sowjuec sowjuec commented Mar 20, 2024

Summary

Fixed Update-VcenterRootPasswordExpiration to handle empty email string parameter

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #171

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Mar 20, 2024
@sowjuec sowjuec marked this pull request as ready for review March 20, 2024 06:24
@sowjuec sowjuec requested a review from a team as a code owner March 20, 2024 06:24
@tenthirtyam tenthirtyam changed the title Fix: fixed Update-VcenterRootPasswordExpiration to handle empty email string parameter fix: update Update-VcenterRootPasswordExpiration empty email handling Mar 21, 2024
@tenthirtyam tenthirtyam self-requested a review March 21, 2024 16:04
@tenthirtyam tenthirtyam added this to the v1.7.2 milestone Mar 21, 2024
@tenthirtyam tenthirtyam force-pushed the Fix-Issue171 branch 2 times, most recently from fe8f993 to 9648b51 Compare March 21, 2024 16:06
Fixed `Update-VcenterRootPasswordExpiration` to handle empty email string.

Ref: vmware#171

Signed-off-by: Sowjanya.V <[email protected]>
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit 597c8be into vmware:develop Mar 21, 2024
1 check passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation
Projects
None yet
2 participants