Skip to content
This repository was archived by the owner on Nov 26, 2025. It is now read-only.

Conversation

@sowjuec
Copy link
Contributor

@sowjuec sowjuec commented Mar 26, 2024

Summary

Fix diff on naming convention change between input file and pester code

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #181

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Mar 26, 2024
@sowjuec sowjuec marked this pull request as ready for review March 26, 2024 09:39
@sowjuec sowjuec requested a review from a team as a code owner March 26, 2024 09:39
@tenthirtyam tenthirtyam changed the title Fix diff on naming convention change between input file and pester code fx: diff on naming convention change between input file and pester code Mar 26, 2024
@tenthirtyam tenthirtyam changed the title fx: diff on naming convention change between input file and pester code fix: diff on input file and pester Mar 26, 2024
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the CHANGELOG item since the whole of the Pester changes will be new in the release.

@sowjuec
Copy link
Contributor Author

sowjuec commented Mar 26, 2024 via email

Fixed diff between `inputdata.json` and the Pester tests.

Ref: vmware#181

Signed-off-by: Sowjanya.V <[email protected]>
@tenthirtyam tenthirtyam changed the title fix: diff on input file and pester fix: diff between inputdata.json and pester tests Mar 26, 2024
@tenthirtyam tenthirtyam added this to the v1.7.2 milestone Mar 26, 2024
@tenthirtyam tenthirtyam merged commit a370fa5 into vmware:develop Mar 26, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Apr 24, 2024
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

One of the change made in input json file of pester testcases is not carried to the code.

2 participants