Skip to content

docs: sanitize examples #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

docs: sanitize examples #226

merged 1 commit into from
Apr 15, 2025

Conversation

tenthirtyam
Copy link
Contributor

Summary

Sanitizes the examples as requested across the division.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

@tenthirtyam tenthirtyam added the documentation Documentation label Apr 14, 2025
@tenthirtyam tenthirtyam added this to the v1.9.0 milestone Apr 14, 2025
@tenthirtyam tenthirtyam self-assigned this Apr 14, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 14, 2025 22:52
@github-actions github-actions bot added the needs-review Needs Review label Apr 14, 2025
Copy link

@andybeltz andybeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments around some typos - otherwise looked good.

@tenthirtyam tenthirtyam force-pushed the docs/sanitize-examples branch from 50482fa to 8eaf7bc Compare April 15, 2025 02:46
@tenthirtyam
Copy link
Contributor Author

Added some comments around some typos - otherwise looked good.

Addressed in 8eaf7bc. for all occurances!

@tenthirtyam tenthirtyam requested a review from andybeltz April 15, 2025 02:51
@tenthirtyam tenthirtyam force-pushed the docs/sanitize-examples branch from 8eaf7bc to 42a8ffb Compare April 15, 2025 02:53
Sanitizes the examples as requested across the division.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the docs/sanitize-examples branch from 42a8ffb to 72f0ca1 Compare April 15, 2025 02:55
Copy link

@andybeltz andybeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit 1c413ea into develop Apr 15, 2025
4 checks passed
@tenthirtyam tenthirtyam deleted the docs/sanitize-examples branch April 15, 2025 05:09
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants