Skip to content

fix: change <...> to [...] for examples #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

tenthirtyam
Copy link
Collaborator

Summary

Changes <...> to [...] for examples.

With this change the module will now import on macOS, Linux, and Windows after changing the examples.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

@tenthirtyam tenthirtyam added the bug Bug label Apr 15, 2025
@tenthirtyam tenthirtyam added this to the v1.9.0 milestone Apr 15, 2025
@tenthirtyam tenthirtyam requested a review from andybeltz April 15, 2025 19:49
@tenthirtyam tenthirtyam self-assigned this Apr 15, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 15, 2025 19:49
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Apr 15, 2025
@tenthirtyam tenthirtyam force-pushed the fix/update-example-syntax branch from 129ad9a to 8d98089 Compare April 15, 2025 21:05
Copy link

@andybeltz andybeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but a few outstanding <>

@tenthirtyam tenthirtyam force-pushed the fix/update-example-syntax branch 2 times, most recently from 94a2487 to d93f8cf Compare April 16, 2025 02:18
@tenthirtyam tenthirtyam force-pushed the fix/update-example-syntax branch 3 times, most recently from 86dea81 to 9318daf Compare April 16, 2025 13:50
@tenthirtyam tenthirtyam force-pushed the fix/update-example-syntax branch 4 times, most recently from 7cd91e5 to d62e94e Compare April 16, 2025 15:28
@tenthirtyam tenthirtyam requested a review from sowjuec April 16, 2025 15:31
@tenthirtyam tenthirtyam force-pushed the fix/update-example-syntax branch from d62e94e to dd317de Compare April 16, 2025 16:22
Changes `<...>` to `[...]` for examples.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the fix/update-example-syntax branch from 490bbf2 to af2b9ff Compare April 16, 2025 17:40
@tenthirtyam tenthirtyam merged commit 2097630 into develop Apr 16, 2025
3 checks passed
@tenthirtyam tenthirtyam deleted the fix/update-example-syntax branch April 16, 2025 17:41
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants