Skip to content

refactor: assigned but unused variables #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: assigned but unused variables #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VMware.CloudFoundation.PasswordManagement.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
RootModule = '.\VMware.CloudFoundation.PasswordManagement.psm1'

# Version number of this module.
ModuleVersion = '1.9.0.1002'
ModuleVersion = '1.9.0.1004'

# ID used to uniquely identify this module
GUID = '34e5a0c7-6e6e-4f72-8b3c-1c28248f8ac9'
Expand Down
51 changes: 23 additions & 28 deletions VMware.CloudFoundation.PasswordManagement.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4195,7 +4195,6 @@ Function Request-VcenterPasswordComplexity {
$pass = Get-Password -username $user -password $pass

Try {
$mgmtConnected = $false
if (Test-VCFConnection -server $server) {
if (Test-VCFAuthentication -server $server -user $user -pass $pass) {
if (Get-VCFWorkloadDomain | Where-Object { $_.name -eq $domain }) {
Expand All @@ -4205,8 +4204,8 @@ Function Request-VcenterPasswordComplexity {
if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) {
if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) {
if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) {
if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) {
$mgmtConnected = $true
if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) {
return
}
}
}
Expand Down Expand Up @@ -4372,8 +4371,8 @@ Function Request-VcenterAccountLockout {
if ($vcenterDomain.type -ne "MANAGEMENT") {
if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "MANAGEMENT")) {
if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) {
if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) {
$mgmtConnected = $true
if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) {
return
}
}
}
Expand Down Expand Up @@ -4556,7 +4555,6 @@ Function Update-VcenterPasswordComplexity {
$pass = Get-Password -username $user -password $pass

Try {
$mgmtConnected = $false
if (Test-VCFConnection -server $server) {
if (Test-VCFAuthentication -server $server -user $user -pass $pass) {
if (Get-VCFWorkloadDomain | Where-Object { $_.name -eq $domain }) {
Expand All @@ -4566,8 +4564,8 @@ Function Update-VcenterPasswordComplexity {
if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) {
if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) {
if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) {
if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) {
$mgmtConnected = $true
if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) {
return
}
}
}
Expand Down Expand Up @@ -4658,16 +4656,15 @@ Function Update-VcenterAccountLockout {
$pass = Get-Password -username $user -password $pass

Try {
$mgmtConnected = $false
if (Test-VCFConnection -server $server) {
if (Test-VCFAuthentication -server $server -user $user -pass $pass) {
if ($vcenterDomain = Get-VCFWorkloadDomain | Where-Object { $_.name -eq $domain }) {
if (($vcfVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domain $domain)) {
if ($vcenterDomain.type -ne "MANAGEMENT") {
if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) {
if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) {
if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) {
$mgmtConnected = $true
if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) {
return
}
}
}
Expand Down Expand Up @@ -5532,8 +5529,8 @@ Function Request-NsxtManagerPasswordComplexity {
if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) {
if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) {
if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) {
if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) {
$mgmtConnected = $true
if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) {
return
}
}
}
Expand Down Expand Up @@ -6221,20 +6218,17 @@ Function Publish-NsxManagerPasswordExpiration {
if (Test-VCFAuthentication -server $server -user $user -pass $pass) {
$nsxManagerPasswordExpirationObject = New-Object System.Collections.ArrayList
if ($PsBoundParameters.ContainsKey('workloadDomain')) {
if (($vcfNsxDetails = Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain $workloadDomain -listNodes)) {
# foreach ($nsxtManagerNode in $vcfNsxDetails.nodes) {
$command = "Request-NsxtManagerPasswordExpiration -server $server -user $user -pass $pass -domain $workloadDomain" + $commandSwitch
$nsxPasswordExpiration = Invoke-Expression $command ; $nsxManagerPasswordExpirationObject += $nsxPasswordExpiration
# }
if (Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain $workloadDomain -listNodes) {
$command = "Request-NsxtManagerPasswordExpiration -server $server -user $user -pass $pass -domain $workloadDomain$commandSwitch"
$nsxPasswordExpiration = Invoke-Expression $command
$nsxManagerPasswordExpirationObject += $nsxPasswordExpiration
}
} elseif ($PsBoundParameters.ContainsKey('allDomains')) {
$allWorkloadDomains = Get-VCFWorkloadDomain
foreach ($domain in $allWorkloadDomains ) {
if (($vcfNsxDetails = Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain $domain.name -listNodes)) {
# foreach ($nsxtManagerNode in $vcfNsxDetails.nodes) {
if (Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain $domain.name -listNodes) {
$command = "Request-NsxtManagerPasswordExpiration -server $server -user $user -pass $pass -domain $($domain.name)" + $commandSwitch
$nsxPasswordExpiration = Invoke-Expression $command ; $nsxManagerPasswordExpirationObject += $nsxPasswordExpiration
# }
}
}
}
Expand Down Expand Up @@ -9508,8 +9502,8 @@ Function Get-AriaLocalUserPasswordExpiration {
if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) {
if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) {
if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) {
if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) {
$mgmtConnected = $true
if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) {
return
}
}
}
Expand Down Expand Up @@ -15561,10 +15555,11 @@ Function Request-LocalUserPasswordExpiration {
if (Test-VCFConnection -server $server) {
if (Test-VCFAuthentication -server $server -user $user -pass $pass) {
if ($drift) {
$version = Get-VCFManager -version
if ($PsBoundParameters.ContainsKey('policyFile')) {
$version = Get-VCFManager -version
$command = '(Get-PasswordPolicyConfig -version $version -reportPath $reportPath -policyFile $policyFile ).' + $product + '.passwordExpiration'
} else {
$version = Get-VCFManager -version
$command = '(Get-PasswordPolicyConfig -version $version).' + $product + '.passwordExpiration'
}
$requiredConfig = Invoke-Expression $command
Expand All @@ -15579,8 +15574,8 @@ Function Request-LocalUserPasswordExpiration {
if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) {
if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) {
if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) {
if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) {
$mgmtConnected = $true
if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) {
return
}
}
}
Expand Down Expand Up @@ -15707,8 +15702,8 @@ Function Update-LocalUserPasswordExpiration {
if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) {
if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) {
if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) {
if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) {
$mgmtConnected = $true
if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) {
return
}
}
}
Expand Down