-
Notifications
You must be signed in to change notification settings - Fork 84
Add GM support to upgrade components #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1b110ec
to
85a6f71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. only some comments about docs
### Upgrading Global Manager | ||
|
||
NSX Global Manager upgrade is similar to Local Manager. Yet, Global Manager has no Edge or Host components and therefore | ||
Doesn't allow the configuration of these in upgrade groups in the `nsxt_upgrade_run` resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "these components"
|
||
## Argument Reference | ||
|
||
In addition to arguments listed above, the following attributes are exported: | ||
|
||
* `upgrade_plan` - (Computed) Upgrade plan for current upgrade. Upgrade unit groups that are not defined in `edge_group` or `host_group` will also be included here. | ||
* `upgrad_group_plan` - (Computed) Upgrade plan for current upgrade. Upgrade unit groups that are not defined in `edge_group` or `host_group` will also be included here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: upgrade_group_plan
@@ -192,6 +192,11 @@ When the ESXi software is not upgraded, the finalization stage will fail. There | |||
the NSX management plane, the Edge appliances and the NSX bits on the ESXi hosts, and postpone the ESXi OS upgrade to | |||
a later time. | |||
|
|||
### Upgrading Global Manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a sample HCL for GM upgrade. I know it's very similar to the LM one, but users appreciate being able to do a cut and paste to get a template they can edit for their TF configuration
Support the upgrade of Global Manager using the Terraform provider. Signed-off-by: Kobi Samoray <[email protected]>
Support the upgrade of Global Manager using the Terraform provider.